bugfix for vapp.RemoveNetwork() and vapp.RemoveNetworkAsync() when removing multiple network sequentially #299
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lvirbalas
approved these changes
Apr 9, 2020
| @@ -11,6 +11,8 @@ NOTES: | |||
| BUGS FIXED: | |||
| * Fix issue in Queries with vCD 10 version, which do not return network pool or provider VDC[#293](https://github.com/vmware/go-vcloud-director/pull/293) | |||
| * Session timeout for media, catalog item upload [#294](https://github.com/vmware/go-vcloud-director/pull/294) | |||
| * Fix `vapp.RemoveNetwork`, `vapp.RemoveNetworkAsync` to use `DELETE` API call instead of update | |||
There was a problem hiding this comment.
What about a comment that this is actual only for 10.1?
There was a problem hiding this comment.
It causes problems not only in 10.1. At least 10.0 and 9.5 also has problems with Terraform's binary test vcd.TestAccVcdVAppVmMultiNIC.tf reendering error similar to https://github.com/terraform-providers/terraform-provider-vcd/issues/473 . I have also tested the example in the issue and it failed on vCD 9.5 with 2.7.0.
Didainius
added a commit
to vmware/terraform-provider-vcd
that referenced
this pull request
Apr 10, 2020
This PR bumps govcd dependency to support 10.1 and also: * Adds a note about NSX-T not being supported yet * Adds a support deprecation warning during apply phase for vCD <=9.1 * Adds a link to changelog in GitHub in main documentation page (https://www.terraform.io/docs/providers/vcd/index.html) * Removes 9.1 from the list of supported versions and adds 10.1 in https://www.terraform.io/docs/providers/vcd/index.html * Uses "Undeploy()" instead of PowerOff() for VMs during update phase * Closes #473 by pulling in vmware/go-vcloud-director#299 .
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR attempts to fix
vapp.RemoveNetworkAsync()andvapp.RemoveNetwork()functions by using http DELETE call on endpointhttps://xxx/api/network/ef005324-a62b-4041-ae8c-c7bec64fb348instead of re-applying whole vApp network configuration with a particular network excluded.It has caused situation where re-applying whole vApp network config gave error because that config was invalid.
One particular place which got impacted by that is Terraform provider with many sequential removals - https://github.com/terraform-providers/terraform-provider-vcd/issues/473