Add support for LDAP and SAML groups #314
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vbauzys
approved these changes
Jun 2, 2020
lvirbalas
approved these changes
Jun 15, 2020
| @@ -7,7 +7,7 @@ default: fmtcheck vet static build | |||
| # test runs the test suite and vets the code | |||
| test: testunit | |||
| @echo "==> Running Functional Tests" | |||
| cd govcd && go test -tags "functional" -timeout=200m -check.vv . | |||
| cd govcd && go test -tags "functional" -timeout=300m -check.vv . | |||
There was a problem hiding this comment.
Please tell more why are you adding additional one hundred minutes to the timeout :)
There was a problem hiding this comment.
It is not related to this exact group PR. I did hit timeouts in general for full suite runs in slower envs that is why I increased the "default".
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for Org group management by introducing the following methods:
Additionally it adds two new methods for
adminOrg-LdapConfigureandLdapDisableto aid automated testing.Testing
Two tests
test_GroupCRUDandtest_GroupFinderGetGenericEntityare added. They are both are run from main testTest_LDAPwhich sets up LDAP configuration in vCD - spawns Photon OS VM and uses testing LDAP container https://github.com/rroemhild/docker-test-openldap inside it (using customization scripts.Note. These tests will not work when run separately because LDAP configuration must be present.
Note. External network with valid IPs and DNS servers must be configured because guest will not be able to pull docker image otherwise.
make testpassed on 9.5 and 10.1. Also on 10.1 using SAML authentication (and enabling SAML group related tests intest_GroupCRUD.