Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve isolation of test tags #320

Merged
merged 7 commits into from
Jul 8, 2020

Conversation

dataclouder
Copy link
Contributor

@dataclouder dataclouder commented Jul 7, 2020

  • Moved functions used by more than one tag to a common area.
  • Added a test to check tags isolation
  • Added a command make tagverify to run the above test
$ make tagverify
==> Checking that code complies with gofmt requirements...
==> Running Tags Tests
=== RUN TagsTest
  --- PASS: TagsTest/api
  --- PASS: TagsTest/functional
  --- PASS: TagsTest/catalog
  --- PASS: TagsTest/vapp
  --- PASS: TagsTest/gateway
  --- PASS: TagsTest/network
  --- PASS: TagsTest/org
  --- PASS: TagsTest/query
  --- PASS: TagsTest/extnetwork
  --- PASS: TagsTest/task
  --- PASS: TagsTest/vm
  --- PASS: TagsTest/vdc
  --- PASS: TagsTest/system
  --- PASS: TagsTest/disk
  --- PASS: TagsTest/lb
  --- PASS: TagsTest/lbAppRule
  --- PASS: TagsTest/lbAppProfile
  --- PASS: TagsTest/lbServerPool
  --- PASS: TagsTest/lbServiceMonitor
  --- PASS: TagsTest/lbVirtualServer
  --- PASS: TagsTest/user
  --- PASS: TagsTest/search
  --- PASS: TagsTest/nsxv
  --- PASS: TagsTest/auth
  --- PASS: TagsTest/affinity
  --- PASS: TagsTest/ALL
--- PASS: TagsTest (49s)

Giuseppe Maxia added 3 commits July 7, 2020 09:47
Move functions used by more than one tag to a common file
@dataclouder dataclouder marked this pull request as ready for review July 7, 2020 07:59
Copy link
Collaborator

@lvirbalas lvirbalas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small comment in-line, also do we need to amend TESTING.md?

CHANGELOG.md Outdated Show resolved Hide resolved
@dataclouder
Copy link
Contributor Author

Small comment in-line, also do we need to amend TESTING.md?

No need. The testing script will find the tags from api_vcd_test.go, thus enforcing in practice the directives we already have in TESTING.md

Copy link
Collaborator

@lvirbalas lvirbalas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, will now look forward to a make testrelease or alike 😄

Copy link
Contributor

@vbauzys vbauzys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dataclouder dataclouder merged commit c4f482d into vmware:master Jul 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants