Add access control calls #329
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 7 commits
July 17, 2020 12:32
* Added methods Client.GetAccessControl, Client.SetAccessControl * Added methods VApp.GetAccessControl, VApp.SetAccessControl, VApp.RemoveAccessControl, VApp.IsShared * Added methods AdminCatalog.GetAccessControl, AdminCatalog.SetAccessControl, AdminCatalog.RemoveAccessControl, AdminCatalog.IsShared * Added methods Catalog.GetAccessControl, Catalog.SetAccessControl, Catalog.RemoveAccessControl, Catalog.IsShared * Added methods Vdc.GetVappControlAccess, AdminOrg.GetCatalogControlAccess, Org.GetCatalogControlAccess
lvirbalas
requested changes
Aug 17, 2020
Didainius
reviewed
Aug 17, 2020
added 7 commits
August 17, 2020 16:41
Didainius
approved these changes
Aug 25, 2020
| @@ -2,6 +2,13 @@ | |||
|
|
|||
| * Improved testing tags isolation [#320](https://github.com/vmware/go-vcloud-director/pull/320) | |||
| * Added command `make tagverify` to check tags isolation tests [#320](https://github.com/vmware/go-vcloud-director/pull/320) | |||
| * Added methods `Client.GetAccessControl`, `Client.SetAccessControl`[#329](https://github.com/vmware/go-vcloud-director/pull/329) | |||
There was a problem hiding this comment.
Maybe worth adding a brief mention about useTenantContextfeature.
vbauzys
approved these changes
Aug 28, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduce access control management for vApps and Catalogs
Client.GetAccessControl,Client.SetAccessControlVApp.GetAccessControl,VApp.SetAccessControl,VApp.RemoveAccessControl,VApp.IsSharedAdminCatalog.GetAccessControl,AdminCatalog.SetAccessControl,AdminCatalog.RemoveAccessControl,AdminCatalog.IsSharedCatalog.GetAccessControl,Catalog.SetAccessControl,Catalog.RemoveAccessControl,Catalog.IsSharedVdc.GetVappAccessControl,AdminOrg.GetCatalogAccessControl,Org.GetCatalogAccessControlVdc.QueryVappList,Vdc.GetVappList,AdminVdc.GetVappList,client.GetQueryType