Improve Roles example for OpenAPI and low level OpenAPI #333
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vbauzys
approved these changes
Sep 16, 2020
govcd/openapi.go
Outdated
| @@ -75,9 +77,15 @@ func (client *Client) OpenApiGetAllItems(apiVersion string, urlRef *url.URL, que | |||
| return fmt.Errorf("OpenAPI is not supported on this VCD version") | |||
| } | |||
|
|
|||
| // Page size is defaulted to 128 (maximum supported number) to reduce HTTP calls and improve performance unless caller | |||
| // provides other value | |||
| const pageSize = "128" | |||
There was a problem hiding this comment.
Do really need this constant? defaultPageSize(queryParams, "128")
There was a problem hiding this comment.
My point was to emphasize it. Hopefully a comment above is sufficient. Removed.
dataclouder
approved these changes
Oct 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR builds on top of #325 to further improve an example with
Rolesas per initial design improvements:OpenApiRolebecomes justRoleas in the end maybe user shouldn’t care what type of API is used – he just needs result in high level API.GetAllOpenApiRolesfunction now returns[]*Role(with client wrapped in) instead of[]*types.Role. That way one can immediatelly callUpdateandDeleteon result.CreateRolefunction has a pointer receiver of parent (*adminOrgin this case).OpenApiGetAllItemswill defaultpageSizeto 128 results (maximum) per page unless caller supplies a value.