Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Standalone VM #356

Merged
merged 22 commits into from
Feb 23, 2021
Merged

Standalone VM #356

merged 22 commits into from
Feb 23, 2021

Conversation

dataclouder
Copy link
Contributor

@dataclouder dataclouder commented Feb 11, 2021

  • Add types to support standalone VM
    • types.CreateVmParams and types.InstantiateVmTemplateParams
  • Rename 'types.VM' to 'types.Vm'
  • Add HREF to VdcComputePolicy struct
  • Add functions to create and retrieve standalone VM
    • Vdc methods CreateStandaloneVMFromTemplate, CreateStandaloneVMFromTemplateAsync CreateStandaloneVm, CreateStandaloneVmAsync
    • Vdc methods QueryVmByName, QueryVmById
  • Add functions to delete standalone VM
    • VM methods Delete, DeleteAsync
  • Add standaloneVm to cleanup function
  • Fix 'VM' mentioning in comments and tests

@dataclouder dataclouder changed the title Standalone vm Standalone VM Feb 11, 2021
@dataclouder dataclouder marked this pull request as ready for review February 17, 2021 15:23
Copy link
Collaborator

@Didainius Didainius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Pass one - I still need to dig into the actual process better (will come back once more after provider PR initial review).

govcd/vdc.go Outdated Show resolved Hide resolved
govcd/vapp.go Outdated Show resolved Hide resolved
govcd/vdc.go Show resolved Hide resolved
govcd/vdc.go Outdated Show resolved Hide resolved
govcd/vdccomputepolicy.go Show resolved Hide resolved
govcd/vdc.go Outdated Show resolved Hide resolved
govcd/api_vcd_test.go Show resolved Hide resolved
govcd/api_vcd_test.go Outdated Show resolved Hide resolved
govcd/api_vcd_test.go Outdated Show resolved Hide resolved
govcd/vdc.go Outdated Show resolved Hide resolved
govcd/vdc.go Outdated Show resolved Hide resolved
types/v56/vm_types.go Outdated Show resolved Hide resolved
types/v56/vm_types.go Show resolved Hide resolved
Copy link
Collaborator

@lvirbalas lvirbalas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@dataclouder dataclouder merged commit 6afe647 into vmware:master Feb 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants