Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not send 'org' filter when used with Org users (fixes queryCatalogByX and queryVDCByX #376

Merged
merged 1 commit into from
May 12, 2021

Conversation

Didainius
Copy link
Collaborator

After API V33.0 bump (#371) GetCatalogById, GetCatalogByName, GetVDCById, GetVDCByName started using queries behind the scenes. Apparently query filters do not accept org filter when being used by Org user. (it does work and is useful with System user).

This PR adjusts filtering to avoid sending org filter when used by Org user.

Signed-off-by: Dainius Serplis <dserplis@vmware.com>
Copy link
Contributor

@dataclouder dataclouder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
We should probably add a test that retrieves the list of VDC/Catalogs as org user. Currently, we are testing indirectly from terraform-provider-vcd.

@Didainius Didainius self-assigned this May 12, 2021
@Didainius Didainius merged commit e0a633c into vmware:master May 12, 2021
@Didainius Didainius deleted the fix_queries branch May 12, 2021 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants