-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add NSX-T Firewall support #381
Conversation
b72bb9d
to
9769fa8
Compare
Signed-off-by: Dainius Serplis <dserplis@vmware.com>
9769fa8
to
78b036b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work! Only one question unrelated to this PR.
|
||
* Added methods `NsxtEdgeGateway.UpdateNsxtFirewall()`, `NsxtEdgeGateway.GetNsxtFirewall()`, `nsxtFirewall.DeleteAll()`, | ||
`nsxtFirewall.DeleteById` [#381](https://github.com/vmware/go-vcloud-director/pull/381) | ||
|
||
BREAKING CHANGES: | ||
* Added parameter `description` to method `vdc.ComposeRawVapp` [#372](https://github.com/vmware/go-vcloud-director/pull/372) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Though unlrelated to this PR, I just noticed this line. Do we break the semver aspect of the govcd versioning here?
CC: @dataclouder
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep - this happened as part of #372
Signed-off-by: Dainius Serplis <dserplis@vmware.com>
Signed-off-by: Dainius Serplis <dserplis@vmware.com>
Signed-off-by: Dainius Serplis <dserplis@vmware.com>
Signed-off-by: Dainius Serplis <dserplis@vmware.com>
Signed-off-by: Dainius Serplis <dserplis@vmware.com>
Signed-off-by: Dainius Serplis <dserplis@vmware.com>
Signed-off-by: Dainius Serplis <dserplis@vmware.com>
This PR adds support for NSX-T Firewall by adding new functions and types:
NsxtEdgeGateway.UpdateNsxtFirewall()
,NsxtEdgeGateway.GetNsxtFirewall()
,nsxtFirewall.DeleteAll()
,nsxtFirewall.DeleteById
,types.NsxtFirewallRule
,types.NsxtFirewallRuleContainer
It also fixes a few errors found by new staticheck: