Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update vdc storage profiles #393

Merged
merged 14 commits into from
Aug 6, 2021
Merged

Update vdc storage profiles #393

merged 14 commits into from
Aug 6, 2021

Conversation

dataclouder
Copy link
Contributor

@dataclouder dataclouder commented Jul 27, 2021 •
edited
Loading

Fixes Issue #648 "adding a storage profile requires the VDC to be replaced"

Ancillary problems related to issue fix:

  • The search for storage profiles was faulty: it does not work at all for name "*";
  • The search could return a storage profile from a Provider VDC different from the one we were using to create the VDC.

Added methods:

  • AdminVdc.AddStorageProfile
  • AdminVdc.AddStorageProfileWait
  • AdminVdc.RemoveStorageProfile
  • AdminVdc.RemoveStorageProfileWait
  • AdminVdc.SetDefaultStorageProfile
  • AdminVdc.GetDefaultStorageProfileReference
  • VCDClient.GetStorageProfileByHref
  • Client.GetStorageProfileByHref
  • VCDClient.QueryProviderVdcStorageProfileByName
  • ClientQueryAllProviderVdcStorageProfiles`
  • Client.QueryProviderVdcStorageProfiles

Giuseppe Maxia added 6 commits July 27, 2021 09:27
Add structure needed to update storage profiles
eb56135 
Signed-off-by: Giuseppe Maxia <gmaxia@vmware.com>
Add methods to add/remove VDC storage profiles
2b6192d 
Signed-off-by: Giuseppe Maxia <gmaxia@vmware.com>
Replace methods used to search storage profiles
2685ba5 
Signed-off-by: Giuseppe Maxia <gmaxia@vmware.com>
Deprecate vdc.GetDefaultStorageProfileReference
1b44fc9 
Signed-off-by: Giuseppe Maxia <gmaxia@vmware.com>
Add tests for storage profile handling
82979da 
Signed-off-by: Giuseppe Maxia <gmaxia@vmware.com>
Fix Catalog deletion
c168b34 
The deletiomn should wait for a task completion, but the previous
implementation didn't

Signed-off-by: Giuseppe Maxia <gmaxia@vmware.com>
@dataclouder dataclouder marked this pull request as draft July 27, 2021 07:50
@dataclouder dataclouder marked this pull request as ready for review July 28, 2021 08:21
Giuseppe Maxia added 3 commits July 28, 2021 10:35
Merge branch 'master' into update-vdc-storage
0b7d26a 
Signed-off-by: Giuseppe Maxia <gmaxia@vmware.com>
Add CHANGELOG items
ff1c886 
Signed-off-by: Giuseppe Maxia <gmaxia@vmware.com>
Update CHANGELOG items
27f9899 
Signed-off-by: Giuseppe Maxia <gmaxia@vmware.com>
Update GitHub Actions runner
3cba4cd 
Signed-off-by: Giuseppe Maxia <gmaxia@vmware.com>
@dataclouder dataclouder requested a review from vbauzys July 28, 2021 10:28
Update GitHub Actions runner
d6e3782 
Signed-off-by: Giuseppe Maxia <gmaxia@vmware.com>
vbauzys
vbauzys approved these changes Jul 28, 2021
View reviewed changes
.changes/v2.13.0/393-features.md Outdated Show resolved Hide resolved
govcd/adminvdc.go Outdated Show resolved Hide resolved
govcd/adminvdc.go Outdated Show resolved Hide resolved
govcd/adminvdc.go Outdated Show resolved Hide resolved
govcd/adminvdc.go Show resolved Hide resolved
govcd/system.go Show resolved Hide resolved
govcd/system.go Outdated Show resolved Hide resolved
Address review remarks
57f5e40 
Also, fix bug in QueryProviderVdcStorageProfileByName

Signed-off-by: Giuseppe Maxia <gmaxia@vmware.com>
lvirbalas
lvirbalas approved these changes Jul 29, 2021
View reviewed changes
Copy link
Collaborator

@lvirbalas lvirbalas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Neat! Only polishes in review.

govcd/adminvdc.go Outdated Show resolved Hide resolved
govcd/adminvdc.go Outdated Show resolved Hide resolved
Giuseppe Maxia added 2 commits July 29, 2021 11:15
[skip ci] improve comments
afb90a2 
Signed-off-by: Giuseppe Maxia <gmaxia@vmware.com>
Fix bug in QueryProviderVdcStorageProfileByName
444f6f9 
Signed-off-by: Giuseppe Maxia <gmaxia@vmware.com>
@dataclouder dataclouder merged commit a7edcad into vmware:master Aug 6, 2021
@lelvisl lelvisl mentioned this pull request Sep 1, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vbauzys vbauzys vbauzys approved these changes

@Didainius Didainius Didainius approved these changes

@lvirbalas lvirbalas lvirbalas approved these changes

Assignees
No one assigned
Labels
cla-not-required
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@dataclouder @lvirbalas @Didainius @vbauzys @vmwclabot