Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Go 1.17 introduced changes to how build tags are defined.
gofmt
automatically fixes that and this PR is just to make sure we are 1.17 compatible so thatmake build
works.Additionally it tunes
sed
command intest-tags.sh
so that it gathers all tags and ignores or||
sign in new build tag format.A longer description.
Go 1.17 started to use new format of build tags (which we use to separate test cases). In Go 1.17
go fmt
command automatically maintains two types of build tags - new and old one. That way the code is still compatible with older Go versions.go fmt
(in Go 1.17) will also keep these build directives in sync (older format with newer one). Additionallygo vet
will capture if these tags are not in sync. Our GitHub workflow will run on Go 1.17 now and it will capture if any of submitted tags are not in sync.Example of how new build directive looks (line1) and older one (line2)