Add support for NSX-T Alb General Settings #403
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Dainius Serplis <dserplis@vmware.com>
Signed-off-by: Dainius Serplis <dserplis@vmware.com>
Signed-off-by: Dainius Serplis <dserplis@vmware.com>
lvirbalas
reviewed
Oct 11, 2021
| @@ -0,0 +1,2 @@ | |||
| * Added type `NsxtAlbConfig` and functions `NsxtEdgeGateway.UpdateAlbSettings`, `NsxtEdgeGateway.GetAlbSettings`, | |||
| `NsxtEdgeGateway.DisableAlb` [GH-403] | |||
There was a problem hiding this comment.
Maybe worth mentioning the helper function too?
There was a problem hiding this comment.
The helper function is a private one made for testing that should not be mentioned in the changes log.
There was a problem hiding this comment.
Yep, I am on this one with dataclouder - it is an internal function used for testing only.
| @@ -78,3 +78,34 @@ func (vcd *TestVCD) Test_GetAllAlbServiceEngineGroups(check *C) { | |||
| err = controller.Delete() | |||
| check.Assert(err, IsNil) | |||
| } | |||
|
|
|||
| // spawnAlbControllerCloudServiceEngineGroup is a helper function to spawn NSX-T ALB Controller,ALB Cloud, and ALB | |||
There was a problem hiding this comment.
Suggested change
| // spawnAlbControllerCloudServiceEngineGroup is a helper function to spawn NSX-T ALB Controller,ALB Cloud, and ALB | |
| // spawnAlbControllerCloudServiceEngineGroup is a helper function to spawn NSX-T ALB Controller, ALB Cloud and ALB |
dataclouder
approved these changes
Oct 13, 2021
| @@ -0,0 +1,2 @@ | |||
| * Added type `NsxtAlbConfig` and functions `NsxtEdgeGateway.UpdateAlbSettings`, `NsxtEdgeGateway.GetAlbSettings`, | |||
| `NsxtEdgeGateway.DisableAlb` [GH-403] | |||
There was a problem hiding this comment.
The helper function is a private one made for testing that should not be mentioned in the changes log.
Signed-off-by: Dainius Serplis <dserplis@vmware.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR starts adding NSX-T ALB support for Tenant view. It is in tenant view, but still requires System user (just like creating an edge gateway)
This is the first resource in series to allow controlling ALB on NSX-T Edge Gateway. It still requires system user to modify, just as creating an edge gateway, but is presented in Tenants view
From technical standpoint it adds type
NsxtAlbConfigand functionsNsxtEdgeGateway.UpdateAlbGeneralSettings,NsxtEdgeGateway.GetAlbGeneralSettings,NsxtEdgeGateway.DisableAlbas well as tests.It also adds another testing helper function
spawnAlbControllerCloudServiceEngineGroupwhich does all Provider side configuration of NSX-T ALB and will be required for all tests in Tenant view.Tests on tag
albhave passed on 10.1 (ALB is not supported there), 10.2 and 10.3