Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for NSX-T ALB Pools #414

Merged
merged 8 commits into from
Dec 20, 2021
Merged

Conversation

Didainius
Copy link
Collaborator

@Didainius Didainius commented Dec 7, 2021

This PR adds support for NSX-T ALB Pools via type NsxtAlbPool and its relevant functions.

  • Moves embedded certificates to separate file so that they can be shared with multiple tests (tags)

Tested on at least one version of 10.2 and 10.3 with tag alb to include all ALB related tests.

Opened in favor of #411 as github is showing messy diff.

Signed-off-by: Dainius Serplis <dserplis@vmware.com>
Signed-off-by: Dainius Serplis <dserplis@vmware.com>
@Didainius Didainius self-assigned this Dec 7, 2021
govcd/openapi.go Outdated Show resolved Hide resolved
Signed-off-by: Dainius Serplis <dserplis@vmware.com>
Signed-off-by: Dainius Serplis <dserplis@vmware.com>
@Didainius Didainius marked this pull request as ready for review December 7, 2021 22:01
Signed-off-by: Dainius Serplis <dserplis@vmware.com>
.changes/v2.14.0/414-features.md Outdated Show resolved Hide resolved
govcd/nsxt_alb_pool.go Outdated Show resolved Hide resolved
govcd/nsxt_alb_pool_test.go Show resolved Hide resolved
govcd/nsxt_alb_pool_test.go Outdated Show resolved Hide resolved
Copy link
Collaborator

@lvirbalas lvirbalas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Signed-off-by: Dainius Serplis <dserplis@vmware.com>
Signed-off-by: Dainius Serplis <dserplis@vmware.com>
@Didainius Didainius merged commit 3cccf38 into vmware:master Dec 20, 2021
@Didainius Didainius deleted the alb-pools-pr-2 branch December 20, 2021 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants