Add VDC Group support for NSX-T Edge Gateways #440
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Dainius Serplis <dserplis@vmware.com>
Didainius
requested review from
lvirbalas,
dataclouder and
vbauzys
as code owners
Signed-off-by: Dainius Serplis <dserplis@vmware.com>
Didainius
changed the title
Didainius
requested review from
mikeletux and
adambarreiro
and removed request for
dataclouder and
vbauzys
lvirbalas
approved these changes
Mar 9, 2022
vbauzys
suggested changes
Mar 15, 2022
Signed-off-by: Dainius Serplis <dserplis@vmware.com>
vbauzys
approved these changes
Mar 17, 2022
Signed-off-by: Dainius Serplis <dserplis@vmware.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for NSX-T Edge Gateway in VDC Groups.
OrgVdctoOwnerReffield.Additional methods
NsxtEdgeGateway.MoveToVdc(),Org.GetNsxtEdgeGatewayByNameAndOwnerId(),VdcGroup.GetNsxtEdgeGatewayByName(),VdcGroup.GetAllNsxtEdgeGateways(),org.GetVdcGroupByIdOwnerIsVdcGroup(),OwnerIsVdc(),VdcGroup.GetCapabilities(),VdcGroup.IsNsxt()Additionally
Test_NsxtEdgeVdcGroupwhich aims to test all the new added things.test_CreateVdcGroupis moved to separate filegovcd/vdc_group_common_test.goso that it can be shared on multiple build tags and reused and create