Fix group.Update() when users list is populated #449
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: abarreiro <abarreiro@vmware.com>
added 2 commits
March 18, 2022 14:59
Signed-off-by: abarreiro <abarreiro@vmware.com>
Signed-off-by: abarreiro <abarreiro@vmware.com>
adambarreiro
requested review from
lvirbalas,
dataclouder,
Didainius and
vbauzys
as code owners
Didainius
reviewed
Mar 21, 2022
|
Also add a note to changelog. |
added 3 commits
March 21, 2022 10:05
Signed-off-by: abarreiro <abarreiro@vmware.com>
Signed-off-by: abarreiro <abarreiro@vmware.com>
lvirbalas
approved these changes
Mar 21, 2022
Done, thanks! |
Didainius
approved these changes
Mar 21, 2022
vbauzys
approved these changes
Mar 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Let's consider that we're working with LDAP users and groups. When a group is read from LDAP, and it contains users, the attribute UsersList is populated with the names of these users. The problem is, if the group is updated, and the users list is sent back, VCD will throw this error:
The proposed fix is to send this attribute always to
nilin thegroup.Update()function.I've also checked what happens with
user.Update(), as common sense would suggest that the behaviour is the same, but it is not. In fact, there's already a check kind of similar to the one proposed, in user.go:414.In this case,
user.Update()worked out of the box, so I haven't touched that part. What I did, in the other hand, is enrich the group test with anuser.Update()call, to have this behaviour covered as well.