Add support for Distributed Firewall and Network Context Profile lookup #452
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Dainius Serplis <dserplis@vmware.com>
Signed-off-by: Dainius Serplis <dserplis@vmware.com>
Signed-off-by: Dainius Serplis <dserplis@vmware.com>
Signed-off-by: Dainius Serplis <dserplis@vmware.com>
Didainius
requested review from
lvirbalas,
dataclouder,
vbauzys,
mikeletux and
adambarreiro
as code owners
adambarreiro
approved these changes
Mar 30, 2022
lvirbalas
approved these changes
Mar 30, 2022
Signed-off-by: Dainius Serplis <dserplis@vmware.com>
mikeletux
approved these changes
Mar 30, 2022
Signed-off-by: Dainius Serplis <dserplis@vmware.com>
Signed-off-by: Dainius Serplis <dserplis@vmware.com>
vbauzys
approved these changes
Mar 31, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for Distributed Firewall Rules and Network Context Profile lookup functions (VCD does not yet support creation of Netwok Context Profiles in UI).
GetAllNetworkContextProfilesandGetNetworkContextProfilesByNameScopeAndContextfunctionsDistributedFirewallandVdcGroup.GetDistributedFirewall,VdcGroup.UpdateDistributedFirewall,VdcGroup.DeleteAllDistributedFirewallRules,DistributedFirewall.DeleteAllRulesNote. Tests with tags
"network nsxt vdcGroup edgegateway"passed on 10.2.0, 10.2.2.2, 10.3.2