added check before getting the admin url

[bogi0704]

Related issue: #461

This PR fixes a small bug which causes an index out of bounds error when calling it as a system org user. I have only added this code since there was no test for GetMetadata() itself.

[vmwclabot]

@bogi0704, you must sign our contributor license agreement before your changes are merged. Click here to sign the agreement. If you are a VMware employee, read this for further instruction.

[adambarreiro]

I'd bet that we have the same issue in other metadata functions that rely on getAdminVdcURL(vdcURL string), my suggestion here would be to fix that function. Maybe instead of:

func getAdminVdcURL(vdcURL string) string {
	return strings.Split(vdcURL, "/api/vdc/")[0] + "/api/admin/vdc/" + strings.Split(vdcURL, "/api/vdc/")[1]
}

We could do:

func getAdminVdcURL(vdcURL string) string {
	return strings.ReplaceAll(vdcURL, "/api/vdc/", "/api/admin/vdc/"))
}

If I'm not wrong this should be working in all cases. What are you thoughts on this?

[bogi0704]

You are right, there are probably other Methods using getAdminVdcURL(vdcURL string) which would benefit from this fix. I have tested your suggestion of the fix and it also works when the vdcURL string already contains "/api/admin/vdc/". So nothing should break.

[vmwclabot]

@bogi0704, VMware has rejected your signed contributor license agreement. The merge can not proceed until the agreement has been resigned. Click here to resign the agreement.

[bogi0704]

The CLA page shows this, so it should be fine now right?:

The Bot probably does not recognize that it is fine.

[adambarreiro]

Hi,
Actually we did a huge refactor of the metadata handling, planned for v3.7.0, in PR #473. In that PR we also included this fix (in a more generic fashion). If you don't mind I think we can close this one.

Thanks a lot!

[vmwclabot]

@bogi0704, VMware has rejected your signed contributor license agreement. The merge can not proceed until the agreement has been resigned. Click here to resign the agreement.