Add DNS option to the NSX-T Segment DHCP server #465
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
April 19, 2022 11:12
…sions Signed-off-by: Miguel Sama <msama@vmware.com>
Signed-off-by: Miguel Sama <msama@vmware.com>
Signed-off-by: Miguel Sama <msama@vmware.com>
Signed-off-by: Miguel Sama <msama@vmware.com>
…rsion function Signed-off-by: Miguel Sama <msama@vmware.com>
Signed-off-by: Miguel Sama <msama@vmware.com>
Signed-off-by: Miguel Sama <msama@vmware.com>
mikeletux
requested review from
lvirbalas,
dataclouder,
Didainius,
vbauzys and
adambarreiro
as code owners
Signed-off-by: Miguel Sama <msama@vmware.com>
lvirbalas
approved these changes
Apr 21, 2022
Didainius
approved these changes
Apr 21, 2022
…enApiHighestElevatedVersion Signed-off-by: Miguel Sama <msama@vmware.com>
vbauzys
approved these changes
Apr 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses the needs on
go-vcloud-directorto allow later feature implementation onterraform-provider-vcdabout DHCP DNS on NSX-T routed networks vmware/terraform-provider-vcd#753Description
This PR allows govcd to be able to set and read DNS servers to/from the Dhcp configuration of a specific Org vDC routed network.
Detailed description
Starting from VCD 10.3.1 (API v36.1) is possible to set the DNS servers that the DHCP sends when configured in a routed NSX-T network.
To allow this, a new field
DnsServershas been added to the structOpenApiOrgVdcNetworkDhcp. Also the methodsVdc.GetOpenApiOrgVdcNetworkDhcpandVdc.UpdateOpenApiOrgVdcNetworkDhcphave been updated to use the methodClient.getOpenApiHighestElevatedVersioninstead ofClient.checkOpenApiEndpointCompatibility, so if VCD 10.3.1 or newer is used, DNS can be set.Also the function
nsxtRoutedDhcpConfighave been slightly to add DnsServers to test that the changes done are perform appropriately.