Add Nsxt route advertisement methods #478
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 10 commits
May 25, 2022 13:30
Signed-off-by: Miguel Sama <msama@vmware.com>
Signed-off-by: Miguel Sama <msama@vmware.com>
Signed-off-by: Miguel Sama <msama@vmware.com>
Signed-off-by: Miguel Sama <msama@vmware.com>
Signed-off-by: Miguel Sama <msama@vmware.com>
Signed-off-by: Miguel Sama <msama@vmware.com>
Signed-off-by: Miguel Sama <msama@vmware.com>
Signed-off-by: Miguel Sama <msama@vmware.com>
Signed-off-by: Miguel Sama <msama@vmware.com>
Signed-off-by: Miguel Sama <msama@vmware.com>
mikeletux
requested review from
lvirbalas,
dataclouder,
Didainius,
vbauzys and
adambarreiro
as code owners
vbauzys
approved these changes
May 31, 2022
lvirbalas
approved these changes
Jun 2, 2022
added 3 commits
June 2, 2022 14:46
Signed-off-by: Miguel Sama <msama@vmware.com>
Signed-off-by: Miguel Sama <msama@vmware.com>
Signed-off-by: Miguel Sama <msama@vmware.com>
Didainius
reviewed
Jun 3, 2022
added 2 commits
June 6, 2022 10:53
Signed-off-by: Miguel Sama <msama@vmware.com>
Signed-off-by: Miguel Sama <msama@vmware.com>
added 3 commits
June 9, 2022 12:25
Signed-off-by: Miguel Sama <msama@vmware.com>
Signed-off-by: Miguel Sama <msama@vmware.com>
Signed-off-by: Miguel Sama <msama@vmware.com>
Didainius
approved these changes
Jun 9, 2022
vbauzys
approved these changes
Jun 9, 2022
added 4 commits
June 14, 2022 15:05
Signed-off-by: Miguel Sama <msama@vmware.com>
Signed-off-by: Miguel Sama <msama@vmware.com>
Signed-off-by: Miguel Sama <msama@vmware.com>
Signed-off-by: Miguel Sama <msama@vmware.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR doesn't have any issue associated
Description
This PR implements new NSX-T edge gateway methods that allow to create route advertisement in NSX-T edge gateways.
Detailed description
This PR proposes three new methods for
NsxtEdgeGatewaythat allows to manage route advertisement. These methods are:NsxtEdgeGateway.GetNsxtRouteAdvertisementNsxtEdgeGateway.UpdateNsxtRouteAdvertisementNsxtEdgeGateway.DeleteNsxtRouteAdvertisementIn order to use these methods, make sure you're using a dedicated Tier-0 gateway:
Or using code:
This PR also introduces a small change (docs) introduced by @vbauzysvmware in file govcd/catalog_test.go