Add support for NSX-T Edge Gateway BGP Neighbor configuration #489
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Dainius Serplis <dserplis@vmware.com>
Signed-off-by: Dainius Serplis <dserplis@vmware.com>
Signed-off-by: Dainius Serplis <dserplis@vmware.com>
Didainius
requested review from
lvirbalas,
vbauzys and
adambarreiro
as code owners
lvirbalas
approved these changes
Jul 13, 2022
adambarreiro
approved these changes
Jul 18, 2022
Signed-off-by: Dainius Serplis <dserplis@vmware.com>
Signed-off-by: Dainius Serplis <dserplis@vmware.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR continues on the track of PRs #480 and #488 and completes coverage of NSX-T Edge Gateway BGP Configuration by adding Neighbor configuration support.
Add support for managing NSX-T Edge Gateway BGP Neighbor. It is done by adding types
EdgeBgpNeighborandtypes.EdgeBgpNeighborwith functionsCreateBgpNeighbor,GetAllBgpNeighbors,GetBgpNeighborByIp,GetBgpNeighborById,UpdateandDeleteNote. VCD 10.2 versions have a problem - they do not return a new entity ID when it is created. Function
CreateBgpNeighborhandles this internally by waiting for task completion and checking if ID was returned (it is returned in 10.3). If the ID is not returned - the function will lookup the entity Neighbor IP address. This should be safe (as opposed to lookup by name inCreateBgpIpPrefixList) as the uniqueness of this IP is enforced by API