Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend Catalog with vApp Template retrieval functions #495

Merged

Conversation

adambarreiro
Copy link
Collaborator

@adambarreiro adambarreiro commented Aug 10, 2022

Description

This PR adds convenience functions to manage vApp Templates to support the implementation of vmware/terraform-provider-vcd#899

  • Catalog and VDC vApp Template retrieval: Functions for Catalog and VDC receiver objects that allow to get a vApp Template by different kind of identifiers such as Name, ID or both.

  • vApp Template deletion: Deletes a vApp Template in an async way (DeleteAsync) or waiting for completion (Delete)

  • New functions to query vApp Templates: Now Catalogs, VDCs and Admin VDCs can query for vApp Templates by name.

  • New functions to extract useful info from a vApp Template: These allow to know interesting facts about the vApp template, such as the Catalog to which it belongs, or the VDC that backs the vApp Template.

Signed-off-by: abarreiro <abarreiro@vmware.com>
abarreiro added 7 commits August 10, 2022 14:10
Signed-off-by: abarreiro <abarreiro@vmware.com>
Signed-off-by: abarreiro <abarreiro@vmware.com>
Signed-off-by: abarreiro <abarreiro@vmware.com>
Signed-off-by: abarreiro <abarreiro@vmware.com>
Signed-off-by: abarreiro <abarreiro@vmware.com>
Signed-off-by: abarreiro <abarreiro@vmware.com>
Signed-off-by: abarreiro <abarreiro@vmware.com>
@adambarreiro adambarreiro self-assigned this Aug 10, 2022
@adambarreiro adambarreiro changed the title Add vApp Template functions Extend Catalog with vApp Template retrieval functions Aug 10, 2022
@adambarreiro adambarreiro marked this pull request as ready for review August 10, 2022 13:37
@adambarreiro
Copy link
Collaborator Author

I'm checking why make static returns exit code 2, in my local it returns 0. 🤔

abarreiro added 2 commits August 10, 2022 15:50
#
Signed-off-by: abarreiro <abarreiro@vmware.com>
#
Signed-off-by: abarreiro <abarreiro@vmware.com>
Copy link
Collaborator

@lvirbalas lvirbalas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one ask: if you have an issue number for which this PR is preparing, please add to the description.

And LGTM! :)

@adambarreiro
Copy link
Collaborator Author

Just one ask: if you have an issue number for which this PR is preparing, please add to the description.

And LGTM! :)

Couldn't find any issue, but added a phrase to point to the resulting PR in terraform-provider-vcd (which has a related issue indeed)

…ctor into complete-vapp-template-functions

Signed-off-by: abarreiro <abarreiro@vmware.com>
govcd/vapptemplate.go Outdated Show resolved Hide resolved
govcd/catalog.go Outdated Show resolved Hide resolved
abarreiro added 3 commits August 23, 2022 09:50
Signed-off-by: abarreiro <abarreiro@vmware.com>
Signed-off-by: abarreiro <abarreiro@vmware.com>
…ctor into complete-vapp-template-functions

Signed-off-by: abarreiro <abarreiro@vmware.com>
Signed-off-by: abarreiro <abarreiro@vmware.com>
abarreiro added 2 commits September 13, 2022 11:23
fmt
Signed-off-by: abarreiro <abarreiro@vmware.com>
Signed-off-by: abarreiro <abarreiro@vmware.com>
abarreiro added 11 commits September 21, 2022 15:44
Signed-off-by: abarreiro <abarreiro@vmware.com>
Signed-off-by: abarreiro <abarreiro@vmware.com>
Signed-off-by: abarreiro <abarreiro@vmware.com>
Signed-off-by: abarreiro <abarreiro@vmware.com>
Signed-off-by: abarreiro <abarreiro@vmware.com>
…ctor into complete-vapp-template-functions

Signed-off-by: abarreiro <abarreiro@vmware.com>
Signed-off-by: abarreiro <abarreiro@vmware.com>
Signed-off-by: abarreiro <abarreiro@vmware.com>
#
Signed-off-by: abarreiro <abarreiro@vmware.com>
#
Signed-off-by: abarreiro <abarreiro@vmware.com>
Signed-off-by: abarreiro <abarreiro@vmware.com>
@adambarreiro adambarreiro marked this pull request as ready for review September 26, 2022 11:02
…ctor into complete-vapp-template-functions

Signed-off-by: abarreiro <abarreiro@vmware.com>
abarreiro added 4 commits September 30, 2022 11:06
Signed-off-by: abarreiro <abarreiro@vmware.com>
Signed-off-by: abarreiro <abarreiro@vmware.com>
…ctor into complete-vapp-template-functions

Signed-off-by: abarreiro <abarreiro@vmware.com>
Signed-off-by: abarreiro <abarreiro@vmware.com>
govcd/vdc_test.go Show resolved Hide resolved
Signed-off-by: abarreiro <abarreiro@vmware.com>
Signed-off-by: abarreiro <abarreiro@vmware.com>
@adambarreiro adambarreiro merged commit 646e456 into vmware:main Oct 19, 2022
@adambarreiro adambarreiro deleted the complete-vapp-template-functions branch October 19, 2022 09:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants