Add org users to govcd test configuration #515
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A new structure `[]tenants` is added to `TestConfig`, to allow connecting as tenant user. When the option `-vcd-test-org-user` (same as what is used in terraform-provider-vcd) is se, the first tenant in the list is selected for connection. To use the second tenant (or an optional third one), we can use the option `-vcd-connect-tenant=1` (or `-vcd-connect-tenant=2` if a third one exists). Signed-off-by: Giuseppe Maxia <gmaxia@vmware.com>
Signed-off-by: Giuseppe Maxia <gmaxia@vmware.com>
dataclouder
requested review from
lvirbalas,
Didainius and
adambarreiro
as code owners
adambarreiro
approved these changes
Nov 2, 2022
Didainius
approved these changes
Nov 3, 2022
Yes. I remember. This change, however, allows existing tests to run as Org user. We will need to add appropriate skip statements if a test is supposed to be used blindly by both admin and org users. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A new structure
[]tenantis added toTestConfig, to allow connecting as tenant user.When the option
-vcd-test-org-user(same as what is used in terraform-provider-vcd) is se, the first tenant in the list is selected for connection.To use the second tenant (or an optional third one), we can use the option
-vcd-connect-tenant=1(or-vcd-connect-tenant=2if a third one exists).