Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Documentation and test improvements for NSX-T Network DHCP type #517

Merged
merged 15 commits into from
Nov 15, 2022
Merged

Documentation and test improvements for NSX-T Network DHCP type #517

merged 15 commits into from
Nov 15, 2022

Conversation

Didainius
Copy link
Collaborator

@Didainius Didainius commented Nov 10, 2022 •
edited
Loading

This PR:

  • Adjusts types.OpenApiOrgVdcNetworkDhcp documentation (only) with latest DHCP features.
  • Adjusts tests to verify DHCP with other types of network.

@Didainius
WIP
cc9ee46 
Signed-off-by: Dainius Serplis <dserplis@vmware.com>
@Didainius
Merge branch 'main' into 255-edge-cluster-support
48d416a
@Didainius
Improvements
186191e 
Signed-off-by: Dainius Serplis <dserplis@vmware.com>
@Didainius
Cleanup
69d4f9c 
Signed-off-by: Dainius Serplis <dserplis@vmware.com>
@Didainius
Improve tst
184ca8d 
Signed-off-by: Dainius Serplis <dserplis@vmware.com>
@Didainius
Move function
489de87 
Signed-off-by: Dainius Serplis <dserplis@vmware.com>
@Didainius
revert
65ef692
@Didainius
Self review
2f9c60f 
Signed-off-by: Dainius Serplis <dserplis@vmware.com>
@Didainius
Address comment
8c55e61 
Signed-off-by: Dainius Serplis <dserplis@vmware.com>
@Didainius
Add new details to DHCP type
9c0d086 
Signed-off-by: Dainius Serplis <dserplis@vmware.com>
@Didainius
Merge branch '255-edge-cluster-support' into 231-vcd-nsxt-network-dhcp
4db8411
@Didainius
Changelog and tests
8727a05 
Signed-off-by: Dainius Serplis <dserplis@vmware.com>
@Didainius
Merge branch 'main' into 231-vcd-nsxt-network-dhcp
b4c7cf9
@Didainius
Merge branch 'main' into 231-vcd-nsxt-network-dhcp
54a3d8c 
Signed-off-by: Dainius Serplis <dserplis@vmware.com>
@Didainius Didainius marked this pull request as ready for review November 15, 2022 10:15
lvirbalas
lvirbalas approved these changes Nov 15, 2022
View reviewed changes
Copy link
Collaborator

@lvirbalas lvirbalas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Only few nits.

types/v56/nsxt_types.go Outdated Show resolved Hide resolved
govcd/openapi_org_network_test.go Outdated Show resolved Hide resolved
@Didainius
Address comments
ab4b367 
Signed-off-by: Dainius Serplis <dserplis@vmware.com>
@Didainius Didainius changed the title Improvements for NSX-T Network DHCP type Documentation and test improvements for NSX-T Network DHCP type Nov 15, 2022
@Didainius Didainius merged commit c89dfe5 into vmware:main Nov 15, 2022
@Didainius Didainius deleted the 231-vcd-nsxt-network-dhcp branch November 15, 2022 11:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dataclouder dataclouder dataclouder approved these changes

@lvirbalas lvirbalas lvirbalas approved these changes

@adambarreiro adambarreiro adambarreiro approved these changes

Assignees
No one assigned
Labels
cla-not-required
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Didainius @adambarreiro @lvirbalas @dataclouder @vmwclabot