Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support to the Runtime Defined Entities (RDE) framework with RDE types (2/3) #545

Merged
merged 43 commits into from
Mar 10, 2023

Conversation

adambarreiro
Copy link
Collaborator

@adambarreiro adambarreiro commented Jan 25, 2023

Overview

This PR is built on top of #527, review and merge that one first.

This PR implements the foundations to onboard the RDE framework to the Terraform VCD Provider, by adding CRUD capabilities of RDE types.

Detailed description

This PR adds the following features:

  • Adds the following new methods to the generic VCDClient:
    • CreateRdeType to create a RDE type.
    • GetAllRdeTypes to get all RDE types, supports parameters like filtering.
    • GetRdeType gets a RDE types with its vendor+namespace+version combination which is unique.
    • GetRdeTypeById gets a RDE type with its URN, which is a combination of its vendor+namespace+version underneath.
  • Adds the following methods to the new DefinedEntityType type:
    • Update updates a RDE type with the given input. It is a bit smart to avoid errors if Name and Schema are not populated for update (ie: User doesn't want to update them, but they're mandatory).
    • Delete deletes a RDE type. The RDE type can't be deleted if it's referenced by some RDE instances.

abarreiro added 6 commits January 25, 2023 10:13
Signed-off-by: abarreiro <abarreiro@vmware.com>
#
Signed-off-by: abarreiro <abarreiro@vmware.com>
Signed-off-by: abarreiro <abarreiro@vmware.com>
Signed-off-by: abarreiro <abarreiro@vmware.com>
Signed-off-by: abarreiro <abarreiro@vmware.com>
Signed-off-by: abarreiro <abarreiro@vmware.com>
abarreiro added 18 commits January 25, 2023 11:02
Signed-off-by: abarreiro <abarreiro@vmware.com>
Signed-off-by: abarreiro <abarreiro@vmware.com>
Signed-off-by: abarreiro <abarreiro@vmware.com>
Signed-off-by: abarreiro <abarreiro@vmware.com>
Signed-off-by: abarreiro <abarreiro@vmware.com>
Signed-off-by: abarreiro <abarreiro@vmware.com>
Signed-off-by: abarreiro <abarreiro@vmware.com>
Signed-off-by: abarreiro <abarreiro@vmware.com>
Signed-off-by: abarreiro <abarreiro@vmware.com>
Signed-off-by: abarreiro <abarreiro@vmware.com>
Signed-off-by: abarreiro <abarreiro@vmware.com>
Signed-off-by: abarreiro <abarreiro@vmware.com>
Signed-off-by: abarreiro <abarreiro@vmware.com>
Signed-off-by: abarreiro <abarreiro@vmware.com>
Signed-off-by: abarreiro <abarreiro@vmware.com>
#
Signed-off-by: abarreiro <abarreiro@vmware.com>
Signed-off-by: abarreiro <abarreiro@vmware.com>
Signed-off-by: abarreiro <abarreiro@vmware.com>
@adambarreiro adambarreiro marked this pull request as ready for review January 27, 2023 12:16
Signed-off-by: abarreiro <abarreiro@vmware.com>
abarreiro added 10 commits January 30, 2023 16:51
Signed-off-by: abarreiro <abarreiro@vmware.com>
Signed-off-by: abarreiro <abarreiro@vmware.com>
Signed-off-by: abarreiro <abarreiro@vmware.com>
Signed-off-by: abarreiro <abarreiro@vmware.com>
Signed-off-by: abarreiro <abarreiro@vmware.com>
Signed-off-by: abarreiro <abarreiro@vmware.com>
Signed-off-by: abarreiro <abarreiro@vmware.com>
Signed-off-by: abarreiro <abarreiro@vmware.com>
Signed-off-by: abarreiro <abarreiro@vmware.com>
Signed-off-by: abarreiro <abarreiro@vmware.com>
@adambarreiro adambarreiro marked this pull request as draft February 8, 2023 09:18
abarreiro added 5 commits February 9, 2023 09:33
Signed-off-by: abarreiro <abarreiro@vmware.com>
Signed-off-by: abarreiro <abarreiro@vmware.com>
Signed-off-by: abarreiro <abarreiro@vmware.com>
Signed-off-by: abarreiro <abarreiro@vmware.com>
Signed-off-by: abarreiro <abarreiro@vmware.com>
Copy link
Collaborator

@Didainius Didainius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, tests passed on 10.4.0 and 10.4.1.

govcd/defined_entity.go Outdated Show resolved Hide resolved
govcd/defined_entity_test.go Outdated Show resolved Hide resolved
govcd/defined_entity.go Outdated Show resolved Hide resolved
govcd/defined_entity_test.go Show resolved Hide resolved
abarreiro added 2 commits March 3, 2023 11:21
Signed-off-by: abarreiro <abarreiro@vmware.com>
Signed-off-by: abarreiro <abarreiro@vmware.com>
govcd/defined_entity_test.go Outdated Show resolved Hide resolved
Signed-off-by: abarreiro <abarreiro@vmware.com>
@adambarreiro adambarreiro merged commit 58f8c31 into vmware:main Mar 10, 2023
@adambarreiro adambarreiro deleted the add-rde-support-2 branch March 10, 2023 11:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants