Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add catalog read-only sharing to all organizations #559

Merged
merged 34 commits into from
Nov 14, 2023
Merged

Add catalog read-only sharing to all organizations #559

merged 34 commits into from
Nov 14, 2023

Conversation

dataclouder
Copy link
Contributor

@dataclouder dataclouder commented Mar 17, 2023 •
edited
Loading

Add types and functions to handle read-only catalog sharing (Address Issue 987)

  • AdminCatalog.SetReadOnlyAccessControl
  • Catalog.SetReadOnlyAccessControl
  • AdminCatalog.IsSharedReadOnly
  • Catalog.IsSharedReadOnly

Note: setting read-only access control for other organizations is the result of two API calls: the first one is an access control request with all parameters set to their zero values, and the second one is a /action/publish (not the same as /action/publishToExternalOrganizations, but will set the catalog's IsPublished status)

Giuseppe Maxia added 4 commits March 17, 2023 09:10
Add types needed for read-only catalog sharing
83aac1c 
Signed-off-by: Giuseppe Maxia <gmaxia@vmware.com>
Add catalog parent retrieval to GetCatalogByHref
18324b2 
Signed-off-by: Giuseppe Maxia <gmaxia@vmware.com>
Add catalog parent retrieval to GetAdminCatalogByHref
c15eaa5 
Signed-off-by: Giuseppe Maxia <gmaxia@vmware.com>
Add functions to handle read-only catalog sharing
d24dcf3 
* AdminCatalog.SetReadOnlyAccessControl
* Catalog.SetReadOnlyAccessControl
* AdminCatalog.IsSharedReadOnly
* Catalog.IsSharedReadOnly

Signed-off-by: Giuseppe Maxia <gmaxia@vmware.com>
Add changelog entries
0996b09 
Signed-off-by: Giuseppe Maxia <gmaxia@vmware.com>
@dataclouder dataclouder self-assigned this Mar 17, 2023
Giuseppe Maxia added 3 commits March 21, 2023 17:04
Improve error messages
3c9000a 
Signed-off-by: Giuseppe Maxia <gmaxia@vmware.com>
Merge branch 'main' into catalog-RO-access-control
a4b3a38 
Signed-off-by: Giuseppe Maxia <gmaxia@vmware.com>
Merge branch 'main' into catalog-RO-access-control
10cf4f9 
Signed-off-by: Giuseppe Maxia <gmaxia@vmware.com>
@juanfont
Copy link

juanfont commented Mar 23, 2023 •
edited
Loading

I confirm this is working :)

Any chance it will be merged soon?

Giuseppe Maxia added 15 commits July 18, 2023 22:41
Add method catalog.WaitForTasks
4069f10 
Signed-off-by: Giuseppe Maxia <gmaxia@vmware.com>
Add WaitForTasks to catalog creation
d5ab5fd 
Signed-off-by: Giuseppe Maxia <gmaxia@vmware.com>
Add test for catalog creation completeness
09df34c 
Signed-off-by: Giuseppe Maxia <gmaxia@vmware.com>
Merge branch 'main' into catalog-RO-access-control
e9c273f 
Signed-off-by: Giuseppe Maxia <gmaxia@vmware.com>
Merge branch 'main' into fix-catalog-creation
4c43eae 
Signed-off-by: Giuseppe Maxia <gmaxia@vmware.com>
Merge branch 'main' into catalog-RO-access-control
f96ca09 
Signed-off-by: Giuseppe Maxia <gmaxia@vmware.com>
Fix merge issues
3089c6c 
Signed-off-by: Giuseppe Maxia <gmaxia@vmware.com>
Merge branch 'fix-catalog-creation' into catalog-RO-access-control
78ca960 
Signed-off-by: Giuseppe Maxia <gmaxia@vmware.com>
Merge branch 'main' into catalog-RO-access-control
baa135e 
Signed-off-by: Giuseppe Maxia <gmaxia@vmware.com>
Improve publishCatalog error message
6300cee 
Signed-off-by: Giuseppe Maxia <gmaxia@vmware.com>
Merge branch 'main' into catalog-RO-access-control
93fa931 
Signed-off-by: Giuseppe Maxia <gmaxia@vmware.com>
Merge branch 'main' into catalog-RO-access-control
fed6eb5 
Signed-off-by: Giuseppe Maxia <gmaxia@vmware.com>
Merge branch 'main' into catalog-RO-access-control
8d4e4af 
Signed-off-by: Giuseppe Maxia <gmaxia@vmware.com>
Merge branch 'main' into catalog-RO-access-control
51bda9a 
Signed-off-by: Giuseppe Maxia <gmaxia@vmware.com>
Merge branch 'main' into catalog-RO-access-control
1f8b8c9 
Signed-off-by: Giuseppe Maxia <gmaxia@vmware.com>
@dataclouder dataclouder marked this pull request as ready for review October 1, 2023 16:21
@dataclouder dataclouder requested a review from adezxc as a code owner October 1, 2023 16:21
adezxc
adezxc approved these changes Oct 2, 2023
View reviewed changes
Copy link

@adezxc adezxc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally, worked great! Just some general questions

govcd/access_control.go Show resolved Hide resolved
govcd/access_control.go Show resolved Hide resolved
govcd/catalog_test.go Show resolved Hide resolved
.changes/v2.20.0/559-features.md Outdated Show resolved Hide resolved
Giuseppe Maxia added 3 commits October 2, 2023 13:52
Move changelog items to current version
f2aa6b9 
Signed-off-by: Giuseppe Maxia <gmaxia@vmware.com>
Add missing assertion to catalog test
6be0423 
Signed-off-by: Giuseppe Maxia <gmaxia@vmware.com>
Rearrange order of publishing functions
15510eb 
Signed-off-by: Giuseppe Maxia <gmaxia@vmware.com>
Giuseppe Maxia added 5 commits October 4, 2023 15:10
Merge branch 'main' into catalog-RO-access-control
2b6a389 
Signed-off-by: Giuseppe Maxia <gmaxia@vmware.com>
Add WaitForTasks to catalog creation
e611c09 
Signed-off-by: Giuseppe Maxia <gmaxia@vmware.com>
Add WaitForTasks to AdminCatalog creation
9c3ab5f 
Signed-off-by: Giuseppe Maxia <gmaxia@vmware.com>
Add function docs
da84810 
Signed-off-by: Giuseppe Maxia <gmaxia@vmware.com>
Fix missing error check
9bef8a1 
Signed-off-by: Giuseppe Maxia <gmaxia@vmware.com>
lvirbalas
lvirbalas approved these changes Oct 9, 2023
View reviewed changes
Copy link
Collaborator

@lvirbalas lvirbalas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some polishing asks :)

govcd/access_control.go Outdated Show resolved Hide resolved
types/v56/types.go Outdated Show resolved Hide resolved
govcd/access_control.go Outdated Show resolved Hide resolved
Update comments
e12d571 
Signed-off-by: Giuseppe Maxia <gmaxia@vmware.com>
adambarreiro
adambarreiro approved these changes Oct 18, 2023
View reviewed changes
Copy link
Collaborator

@adambarreiro adambarreiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Giuseppe Maxia added 2 commits October 26, 2023 20:24
Merge branch 'main' into catalog-RO-access-control
829fda2 
Signed-off-by: Giuseppe Maxia <gmaxia@vmware.com>
Merge branch 'main' into catalog-RO-access-control
f241b4f 
Signed-off-by: Giuseppe Maxia <gmaxia@vmware.com>
@dataclouder dataclouder merged commit 00d27a5 into vmware:main Nov 14, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adezxc adezxc adezxc approved these changes

@Didainius Didainius Didainius approved these changes

@lvirbalas lvirbalas lvirbalas approved these changes

@adambarreiro adambarreiro adambarreiro approved these changes

Assignees

@dataclouder dataclouder

Labels
cla-not-required
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@dataclouder @juanfont @adambarreiro @lvirbalas @Didainius @adezxc @vmwclabot