NSX-T ALB Virtual Service Transparent mode and Pool Firewall Group membership (VCD 10.4.1+) #560
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Dainius Serplis <dserplis@vmware.com>
Signed-off-by: Dainius Serplis <dserplis@vmware.com>
Signed-off-by: Dainius Serplis <dserplis@vmware.com>
Signed-off-by: Dainius Serplis <dserplis@vmware.com>
Signed-off-by: Dainius Serplis <dserplis@vmware.com>
Didainius
changed the title
Signed-off-by: Dainius Serplis <dserplis@vmware.com>
Didainius
requested review from
lvirbalas,
adambarreiro,
dataclouder and
adezxc
as code owners
adezxc
approved these changes
Mar 22, 2023
…Group is not present Signed-off-by: Dainius Serplis <dserplis@vmware.com>
Signed-off-by: Dainius Serplis <dserplis@vmware.com>
dataclouder
approved these changes
Mar 23, 2023
Signed-off-by: Dainius Serplis <dserplis@vmware.com>
lvirbalas
approved these changes
Mar 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR continues on #549 and further catches up with latest NSX-T ALB features (requiring VCD 10.4.1+).
In this PR there are two features:
MemberGroupRef(which are NSX-T IP Sets)Note that transparent mode can only be enabled when ALB Pools are configured to use above mentioned
MemberGroupRefand the backing Service Engine Group inside AVI is configured to use Service Engine Group configured in "Active-Standby" modeNotes
NsxtAlbServiceEngineGroupis introduced. Previously we relied on aDefaultService Engine Group that was created, but Transparent mode requires Service Engine Group configured in "Active-Standby" mode therefore it must be specified.Side note:
This PR includes a generic function
addrOfwhich should be a solution to replace all our type-limited functionstakeBoolPointer,takeIntAddress,takeStringPointer. I did not pollute this PR with replacements as that can be done at a later timeTesting
albtests passed on 10.3.0, 10.3.3, 10.4.0, 10.4.1