Amend Defined Interface updates #566
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: abarreiro <abarreiro@vmware.com>
added 2 commits
April 17, 2023 12:01
Signed-off-by: abarreiro <abarreiro@vmware.com>
adambarreiro
requested review from
lvirbalas,
Didainius,
dataclouder and
adezxc
as code owners
Didainius
approved these changes
Apr 17, 2023
Signed-off-by: abarreiro <abarreiro@vmware.com>
dataclouder
approved these changes
Apr 18, 2023
adezxc
approved these changes
Apr 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
It seems VCD 10.4.2 require the
nss,vendorandversionto be sent back on Defined Interface updates.This issue can be reproduced running the test
Test_DefinedInterfacein VCD 10.4.2.This patch fixes this situation.
This PR does the same patch for Defined Entity Types, despite this one doesn't fail, just to have the same behaviour in both places.