Fix catalog creation #590
Merged
Fix catalog creation #590
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
July 18, 2023 22:41
Signed-off-by: Giuseppe Maxia <gmaxia@vmware.com>
Signed-off-by: Giuseppe Maxia <gmaxia@vmware.com>
Signed-off-by: Giuseppe Maxia <gmaxia@vmware.com>
Signed-off-by: Giuseppe Maxia <gmaxia@vmware.com>
dataclouder
requested review from
lvirbalas,
Didainius,
adambarreiro and
adezxc
as code owners
adambarreiro
approved these changes
Jul 21, 2023
adezxc
approved these changes
Jul 21, 2023
Didainius
approved these changes
Jul 24, 2023
|
Missing changelog entry |
Signed-off-by: Giuseppe Maxia <gmaxia@vmware.com>
lvirbalas
approved these changes
Jul 26, 2023
dataclouder
pushed a commit
to dataclouder/go-vcloud-director
that referenced
this pull request
Jul 31, 2023
The creation task may not be available after a recent fix to catalog creation (PR vmware#590). Accessing the task directly may lead to a panic. The check is replaced with a more resilient function call (ResourceComplete) Signed-off-by: Giuseppe Maxia <gmaxia@vmware.com>
dataclouder
added a commit
that referenced
this pull request
Aug 2, 2023
* Fix Test_AdminOrgCreateCatalog
The creation task may not be available after a recent fix
to catalog creation (PR #590). Accessing the task directly
may lead to a panic. The check is replaced with a more
resilient function call (ResourceComplete)
* Add changelog item
* Fix Test_OrgCreateCatalog
* Avoid infinite loop in Test_VmShutdown
---------
Signed-off-by: Giuseppe Maxia <gmaxia@vmware.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes sure that the created catalog runs its creation tasks completely, and it is ready to perform operations, such as updating or adding metadata.
This change will be completed in
terraform-provider-vcdby removing the functionwaitForMetadataReadiness, which will become redundant.