Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix NSX-V Edge Gateway nil pointer dereference #594

Merged
merged 2 commits into from
Jul 31, 2023

Conversation

adezxc
Copy link

@adezxc adezxc commented Jul 21, 2023

NSX-V Edge gateways can come without any services configured so we need to check for nil pointers.

Closes Issue #585

Signed-off-by: Adam Jasinski <jasinskia@vmware.com>
Copy link
Collaborator

@Didainius Didainius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Title of this PR is incorrect (it mentions ...NSX-T Edge....)
  • Missing changelog

@adezxc adezxc changed the title Fix NSX-T Edge Gateway nil pointer dereference Fix NSX-V Edge Gateway nil pointer dereference Jul 24, 2023
Signed-off-by: Adam Jasinski <jasinskia@vmware.com>
Copy link
Collaborator

@lvirbalas lvirbalas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thanks!

Copy link
Collaborator

@adambarreiro adambarreiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@adezxc adezxc merged commit f85a489 into vmware:main Jul 31, 2023
@adezxc adezxc deleted the nat_rule_fix branch July 31, 2023 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants