Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve RDE related methods #615

Merged
merged 6 commits into from
Oct 5, 2023

Conversation

adambarreiro
Copy link
Collaborator

This PR modifies the following:

  • Makes DefinedEntityType.SetBehaviorAccessControls more robust to avoid NullPointerException errors in VCD side when the input is a nil slice.

#
Signed-off-by: abarreiro <abarreiro@vmware.com>
#
Signed-off-by: abarreiro <abarreiro@vmware.com>
#
Signed-off-by: abarreiro <abarreiro@vmware.com>
@adambarreiro adambarreiro marked this pull request as ready for review September 12, 2023 09:58
Signed-off-by: abarreiro <abarreiro@vmware.com>
Copy link
Contributor

@dataclouder dataclouder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add a test to demonstrate the assumption? i.e. getting an array of nil as input

abarreiro added 2 commits October 2, 2023 16:32
Signed-off-by: abarreiro <abarreiro@vmware.com>
Signed-off-by: abarreiro <abarreiro@vmware.com>
@adambarreiro adambarreiro merged commit f7ceaa7 into vmware:main Oct 5, 2023
2 checks passed
@adambarreiro adambarreiro deleted the improve-rde-methods branch October 5, 2023 07:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants