Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add vGPU policy support #633

Merged
merged 7 commits into from
Dec 4, 2023
Merged

Add vGPU policy support #633

merged 7 commits into from
Dec 4, 2023

Conversation

adezxc
Copy link

@adezxc adezxc commented Nov 27, 2023

This is a simple PR that adds methods and types to read and manage vGPU profiles.

Also updates the VdcComputePolicyV2 to support creation and management of vGPU policies.

Adam Jasinski added 4 commits November 21, 2023 12:15
Signed-off-by: Adam Jasinski <jasinskia@vmware.com>
Signed-off-by: Adam Jasinski <jasinskia@vmware.com>
Signed-off-by: Adam Jasinski <jasinskia@vmware.com>
Signed-off-by: Adam Jasinski <jasinskia@vmware.com>
@adezxc
Copy link
Author

adezxc commented Nov 27, 2023

Reminder: create changelog entry when we consider the feature complete

Copy link
Collaborator

@adambarreiro adambarreiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, just a few things to change/add

govcd/vgpu_profile.go Outdated Show resolved Hide resolved
govcd/vgpu_profile.go Show resolved Hide resolved
Copy link
Collaborator

@Didainius Didainius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one looks simple, but need to get over Terraform :)

Copy link
Collaborator

@lvirbalas lvirbalas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

Adam Jasinski added 3 commits December 4, 2023 11:30
Signed-off-by: Adam Jasinski <jasinskia@vmware.com>
Signed-off-by: Adam Jasinski <jasinskia@vmware.com>
Signed-off-by: Adam Jasinski <jasinskia@vmware.com>
@adezxc adezxc merged commit 9837630 into vmware:main Dec 4, 2023
2 checks passed
@adezxc adezxc deleted the vgpu_policies branch December 4, 2023 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants