Fix bug where CSE cluster is missing certificates when VCDKEConfig has certificates configured #653
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: abarreiro <abarreiro@vmware.com>
Signed-off-by: abarreiro <abarreiro@vmware.com>
adambarreiro
requested review from
lvirbalas,
Didainius and
dataclouder
as code owners
adambarreiro
changed the title
Signed-off-by: abarreiro <abarreiro@vmware.com>
lvirbalas
approved these changes
Mar 14, 2024
Didainius
approved these changes
Mar 14, 2024
dataclouder
approved these changes
Mar 14, 2024
added 2 commits
March 14, 2024 13:28
Signed-off-by: abarreiro <abarreiro@vmware.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR #645 had a bug when the CSE Server is configured (VCDKEConfig RDE) with custom certificates during installation (to use them against a custom private Docker registry), these need to be injected into the cluster YAML as well.
This PR amends that and updates unit tests.