Fix Test_NsxtL2VpnTunnel for VCD 10.5.1.1+ #659
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Dainius Serplis <dserplis@vmware.com>
Signed-off-by: Dainius Serplis <dserplis@vmware.com>
Didainius
requested review from
lvirbalas,
adambarreiro and
dataclouder
as code owners
adambarreiro
approved these changes
Apr 10, 2024
Signed-off-by: Dainius Serplis <dserplis@vmware.com>
dataclouder
approved these changes
Apr 12, 2024
lvirbalas
approved these changes
Apr 12, 2024
Signed-off-by: Dainius Serplis <dserplis@vmware.com>
Improved. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
VCD 10.5.1.23400185 returns 6 asterisks for presharedkey and that causes check to fail in
Test_NsxtL2VpnTunnel. This PR patches test to match these values.Note Terraform is not affected as it does not set the PreSharedKey value.
Test
Test_NsxtL2VpnTunnelpassed on both 10.5.1.1 and 10.5.1