Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add namespaces to VM extra config methods #691

Merged
merged 2 commits into from
Jul 2, 2024
Merged

Add namespaces to VM extra config methods #691

merged 2 commits into from
Jul 2, 2024

Conversation

adambarreiro
Copy link
Collaborator

@adambarreiro adambarreiro commented Jul 2, 2024 •
edited
Loading

Fixes the issue with XML namespaces when using the virtualHardwareSection endpoint:

Undeclared namespace prefix "ns3" (for attribute "ipAddressingMode")

or

Undeclared namespace prefix "ns2" (for attribute "ipAddressingMode")

Fix VM extra config
28256d2 
Signed-off-by: abarreiro <abarreiro@vmware.com>
@adambarreiro adambarreiro self-assigned this Jul 2, 2024
#
7a9139e 
Signed-off-by: abarreiro <abarreiro@vmware.com>
@adambarreiro adambarreiro marked this pull request as ready for review July 2, 2024 10:04
@adambarreiro adambarreiro changed the title Fix VM extra config Add namespaces to VM extra config methods Jul 2, 2024
@Didainius Didainius mentioned this pull request Jul 2, 2024
Merged
@adambarreiro adambarreiro merged commit e415876 into vmware:main Jul 2, 2024
2 checks passed
@adambarreiro adambarreiro deleted the fixes branch July 2, 2024 10:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Didainius Didainius Didainius approved these changes

@dataclouder dataclouder dataclouder approved these changes

@lvirbalas lvirbalas lvirbalas approved these changes

Assignees

@adambarreiro adambarreiro

Labels
cla-not-required
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@adambarreiro @lvirbalas @dataclouder @Didainius @vmwclabot