Use set to avoid the duplicate vifs when searching by owner_vm_id #204
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In some corner case, according to the response of vif search API, there can be 2 vifs for the same VM, which including the same lport_attachment_id and MAC. To avoid store the same attachent id in the variable attachment_ids, we change the var type from list to set.
heypnus
force-pushed
the
fix/multi-vifs-with-same-attach
branch
from
8278f63
to
2cca823
Compare
which including the same lport_attachment_id and MAC -> "which includes the same lport_attachment_id and MAC", is it better? |
timdengyun
reviewed
Oct 11, 2022
timdengyun
approved these changes
Oct 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In some corner case, according to the response of vif search API, there can be 2 vifs for the same VM, which including the same lport_attachment_id and MAC. To avoid store the same attachent id in the variable attachment_ids, we change the var type from list to set.