[JSCLient]Improve CLI Script on adding encoding source string feature. #2102
Conversation
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## g11n-js-client #2102 +/- ##
===============================================
Coverage 77.10% 77.10%
===============================================
Files 20 20
Lines 1559 1559
Branches 627 627
===============================================
Hits 1202 1202
Misses 249 249
Partials 108 108
Flags with carried forward coverage won't be shown. Click here to find out more. Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| logger.error("The encoding type '" + encode + "' is not supported."); | ||
| return; | ||
| } | ||
| const cliOptions = { |
Check notice
Code scanning / Jshint (reported by Codacy)
Prohibits the use of __iterator__ property due to compatibility issues
| encode: encode, | ||
| }; | ||
|
|
||
| let collectSourceBundle = new CollectSourceBundle(logger, vipService, vipConfig, cliOptions); |
Check notice
Code scanning / Jshint (reported by Codacy)
Prohibits the use of __iterator__ property due to compatibility issues
| @@ -30,16 +31,22 @@ | |||
| return this.vipService.collectSources(sourceSet); | |||
| } | |||
| convertDataForVIP(data) { | |||
| const isEncode = this.cliOptions.encode ? true : false; | |||
Check notice
Code scanning / Jshint (reported by Codacy)
Prohibits the use of __iterator__ property due to compatibility issues
| @@ -163,7 +178,16 @@ | |||
| try { | |||
| let vipConfig = new VIPConfig(args.host, args.product, args.version, args.component); | |||
| let vipService = new VIPService(vipConfig, logger, null); | |||
| let collectSourceBundle = new CollectSourceBundle(logger, vipService, vipConfig); | |||
| let encode = args.encode && args.encode.toUpperCase(); | |||
Check notice
Code scanning / Jshint (reported by Codacy)
Prohibits the use of __iterator__ property due to compatibility issues
| @@ -30,16 +31,25 @@ | |||
| return this.vipService.collectSources(sourceSet); | |||
| } | |||
| convertDataForVIP(data) { | |||
| const isEncode = this.cliOptions.encode ? true : false; | |||
| const sourceFormat = isEncode ? this.cliOptions.encode + ",STRING" : "STRING"; | |||
Check notice
Code scanning / Jshint (reported by Codacy)
Prohibits the use of __iterator__ property due to compatibility issues
| sourceSet.push({ | ||
| commentForSource: '', | ||
| key: i, | ||
| source: data[i] | ||
| source, | ||
| sourceFormat, |
Check notice
Code scanning / Jshint (reported by Codacy)
Prohibits the use of __iterator__ property due to compatibility issues
| sourceSet.push({ | ||
| commentForSource: '', | ||
| key: i, | ||
| source: data[i] | ||
| source, |
Check notice
Code scanning / Jshint (reported by Codacy)
Prohibits the use of __iterator__ property due to compatibility issues
| var sourceSet = []; | ||
| for (let i in data) { | ||
| const source = isEncode ? this.encodeString(data[i]) : data[i]; |
Check notice
Code scanning / Jshint (reported by Codacy)
Prohibits the use of __iterator__ property due to compatibility issues
No description provided.