Microsoft Translator API Regional Source Support #566
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nannany00
requested review from
tigershi,
linr211,
Xiaochao8,
huihuiw01 and
jin-jasper
|
@deeDude, VMware has approved your signed contributor license agreement. |
linr211
previously approved these changes
May 21, 2020
Xiaochao8
previously approved these changes
May 21, 2020
|
@deeDude |
@Xiaochao8 Its done, already signed that commit. My apologies for the lapse. Thanks |
linr211
approved these changes
Jun 3, 2020
Xiaochao8
approved these changes
Jun 3, 2020
|
Travis CI hangs, please close this PR and reopen it to see if CI would start. Another people meet same issue, he reopen PR to fix the issue. @deeDude |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the possibility of configuring Microsoft Translator regional endpoint, according to Azure geographies.
A new property,
mt.region, was added on application-bundle.properties , and, once this property is set to a non-empty value, the header, Ocp-Apim-Subscription-Region, will be included in the request to the Microsot Translator API endpoint.