Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updates for README main AWS folder #316

Merged
merged 2 commits into from
Jan 17, 2022
Merged

Updates for README main AWS folder #316

merged 2 commits into from
Jan 17, 2022

Conversation

itlinux
Copy link
Contributor

@itlinux itlinux commented Jan 12, 2022

README had old info. Fixed.

@vmwclabot
Copy link
Member

@itlinux, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding Signed-off-by: John Doe <john.doe@email.org> to the last line of each Git commit message. The e-mail address used to sign must match the e-mail address of the Git author. Click here to view the Developer Certificate of Origin agreement.

mayank-avinetworks
mayank-avinetworks reviewed Jan 17, 2022
View reviewed changes
examples/aws/README.md Outdated
- To configure cloud of type CLOUD_AWS on AVI controller. [Click here](https://avinetworks.com/docs/21.1/configuring-avi-vantage-for-application-delivery-in-amazon-web-services/) for detailed cloud configuration guide.
- To configure Virtual Service and dependent resources in AWS environment. [Click here](https://avinetworks.com/docs/21.1/configuration-guide/applications/virtual-services/) for detailed guide to configure virtual service.
- Update required AVI terraform provider version in versions.tf file.
- Update required variables in variables.tf file or you can set those variables individually while running you terraform plan using -var or define those in .tfvars files.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo: while running you terraform plan

mayank-avinetworks
mayank-avinetworks approved these changes Jan 17, 2022
View reviewed changes
Copy link
Contributor

@mayank-avinetworks mayank-avinetworks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pls fix the typo mentioned in comment and merge.

@vmwclabot
Copy link
Member

@itlinux, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding Signed-off-by: John Doe <john.doe@email.org> to the last line of each Git commit message. The e-mail address used to sign must match the e-mail address of the Git author. Click here to view the Developer Certificate of Origin agreement.

@mayank-avinetworks mayank-avinetworks merged commit b44beb2 into vmware:eng Jan 17, 2022
@itlinux itlinux deleted the aws_readme branch January 17, 2022 04:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mayank-avinetworks mayank-avinetworks mayank-avinetworks approved these changes

@manojkumarjain manojkumarjain Awaiting requested review from manojkumarjain

Assignees
No one assigned
Labels
dco-required
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@itlinux @vmwclabot @mayank-avinetworks