vmware · Rohan-sss1 · Sep 11, 2024
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,42 +1,4 @@
-## 31.1.1 (Unreleased)
-## 30.2.2 (Sept 11, 2024)
-## 30.2.1 (May 08, 2024)
-ENHANCEMENTS:
-- Added new resource `avi_controllerportalregistration` [#553](https://github.com/vmware/terraform-provider-avi/pull/553)
-- Added new resource `avi_serviceauthprofile` [#553](https://github.com/vmware/terraform-provider-avi/pull/553)
-- Added new resource `avi_taskjournal` [#590](https://github.com/vmware/terraform-provider-avi/pull/590)
-
-BUG FIXES:
-- AV-202599 Resource avi_useraccount fails with generic error instead of providing user useful feedback
-- Failure to create avi_useraccount resource. https://github.com/vmware/terraform-provider-avi/issues/314
-- AV-187301: Entering wrong credentials on terraform using AVI as provider, while using Plan command breaks statefile
-- AV-186452: AVI-provider for Terraform version 22.1.2 and 22.1.4 creates any object in the Admin tenant.
-- AV-186737: Changes to certain subresources are not detected as changes by Terraform
-- AV-187199: AVI terraform apply the resource object even if it is already exist without showing Error.
-- Terraform Provider Avi overwriting existing resources. https://github.com/vmware/terraform-provider-avi/issues/358
-- AV-194160 Terraform Provider crash during avi_serviceenginegroup destroy. https://github.com/vmware/terraform-provider-avi/issues/376
-
-## 22.1.6 (March 08, 2024)
-NOTE:
-
-From version 22.1.6, updating system default configurations now requires first importing the existing configuration into the Terraform state.
-
-Please refer [README.MD](https://github.com/vmware/terraform-provider-avi/tree/22.1.7)
-
-ENHANCEMENTS:
-- Added new resource `avi_systemreport` [#576](https://github.com/vmware/terraform-provider-avi/pull/576/files)
-- Updated resources with newly added fields [#576](https://github.com/vmware/terraform-provider-avi/pull/576/files)
-
-BUG FIXES:
-- AV-187199: AVI terraform apply the resource object even if it is already exist without showing Error.
-- Terraform Provider Avi overwriting existing resources. https://github.com/vmware/terraform-provider-avi/issues/358
-
-## 22.1.5 (October 30, 2023)
-BUG FIXES:
-- AV-187301: Entering wrong credentials on terraform using AVI as provider, while using Plan command breaks statefile
-- AV-186452: AVI-provider for Terraform version 22.1.2 and 22.1.4 creates any object in the Admin tenant.
-- AV-186737: Changes to certain subresources are not detected as changes by Terraform
-
+## 0.3.0 (Unreleased)
 ## 0.2.3 (June 16, 2020)
 Features:
 - Updated Avi Go SDK to latest.

diff --git a/GNUmakefile b/GNUmakefile
@@ -9,11 +9,11 @@ build: fmtcheck
 
 build13: GOOS=$(shell go env GOOS)
 build13: GOARCH=$(shell go env GOARCH)
-build13: DESTINATION=$(HOME)/.terraform.d/plugins/$(AVI_PROVIDER_NAMESPACE)/30.2.2/$(GOOS)_$(GOARCH)
+build13: DESTINATION=$(HOME)/.terraform.d/plugins/$(AVI_PROVIDER_NAMESPACE)/30.2.1/$(GOOS)_$(GOARCH)
 build13: fmtcheck
 	@echo "==> Installing plugin to $(DESTINATION)"
 	@mkdir -p $(DESTINATION)
-	go build -o $(DESTINATION)/terraform-provider-avi_v30.2.2
+	go build -o $(DESTINATION)/terraform-provider-avi_v30.2.1
 
 test: fmtcheck
 	go test -i $(TEST) || exit 1

diff --git a/README.md b/README.md
@@ -166,23 +166,3 @@ Running the tests for a provider requires version 0.12.26 or higher of the Terra
 ```sh
 $ make testacc
 ```
-
-Note
------------------
-From version 22.1.6, updating system default configurations now requires first importing the existing configuration into the Terraform state.
-
-#### Here are the steps to update the system default configurations
-Lets consider you have to update the backupconfiguration object
-
-```
-resource "avi_backupconfiguration" "abc" {
-  name                   = "Backup-Configuration"
-  save_local             = true
-  maximum_backups_stored = 4
-  backup_passphrase      = var.password
-}
-```
-Follow these steps
-1. Obtain the UUID of the object via the Controller CLI (`show backupconfiguration`) or by logging in to the Controller UI and browsing to `https://<controller>/api/backupconfiguration`
-2. After obtaining the UUID, import the existing resource into the Terraform state file using `terraform import avi_backupconfiguration.abc <uuid>`
-3. Apply the desired changes to the resource by executing `terraform apply`.
diff --git a/avi/data_source_avi_customipamdnsprofile_test.go b/avi/data_source_avi_customipamdnsprofile_test.go
@@ -26,7 +26,7 @@ func TestAVIDataSourceCustomIpamDnsProfileBasic(t *testing.T) {
 
 }
 
-// nolint
+//nolint
 const testAccAVIDSCustomIpamDnsProfileConfig = `
 data "avi_tenant" "default_tenant"{
     name= "admin"

diff --git a/avi/data_source_avi_dnspolicy_test.go b/avi/data_source_avi_dnspolicy_test.go
@@ -26,7 +26,7 @@ func TestAVIDataSourceDnsPolicyBasic(t *testing.T) {
 
 }
 
-// nolint
+//nolint
 const testAccAVIDSDnsPolicyConfig = `
 data "avi_tenant" "default_tenant"{
     name= "admin"

diff --git a/avi/data_source_avi_ipaddrgroup_test.go b/avi/data_source_avi_ipaddrgroup_test.go
@@ -26,7 +26,7 @@ func TestAVIDataSourceIpAddrGroupBasic(t *testing.T) {
 
 }
 
-// nolint
+//nolint
 const testAccAVIDSIpAddrGroupConfig = `
 data "avi_tenant" "default_tenant"{
     name= "admin"

diff --git a/avi/data_source_avi_ipamdnsproviderprofile_test.go b/avi/data_source_avi_ipamdnsproviderprofile_test.go
@@ -28,7 +28,7 @@ func TestAVIDataSourceIpamDnsProviderProfileBasic(t *testing.T) {
 
 }
 
-// nolint
+//nolint
 const testAccAVIDSIpamDnsProviderProfileConfig = `
 data "avi_tenant" "default_tenant"{
     name= "admin"

diff --git a/avi/datasource_avi_customipamdnsprofile.go b/avi/datasource_avi_customipamdnsprofile.go
@@ -5,7 +5,7 @@ package avi
 
 import "github.com/hashicorp/terraform-plugin-sdk/v2/helper/schema"
 
-// nolint
+//nolint
 func dataSourceAviCustomIpamDnsProfile() *schema.Resource {
 	return &schema.Resource{
 		Read: ResourceAviCustomIpamDnsProfileRead,

diff --git a/avi/datasource_avi_dnspolicy.go b/avi/datasource_avi_dnspolicy.go
@@ -5,7 +5,7 @@ package avi
 
 import "github.com/hashicorp/terraform-plugin-sdk/v2/helper/schema"
 
-// nolint
+//nolint
 func dataSourceAviDnsPolicy() *schema.Resource {
 	return &schema.Resource{
 		Read: ResourceAviDnsPolicyRead,

diff --git a/avi/datasource_avi_dynamicdnsrecord.go b/avi/datasource_avi_dynamicdnsrecord.go
@@ -5,7 +5,7 @@ package avi
 
 import "github.com/hashicorp/terraform-plugin-sdk/v2/helper/schema"
 
-// nolint
+//nolint
 func dataSourceAviDynamicDnsRecord() *schema.Resource {
 	return &schema.Resource{
 		Read: ResourceAviDynamicDnsRecordRead,

diff --git a/avi/datasource_avi_ipaddrgroup.go b/avi/datasource_avi_ipaddrgroup.go
@@ -5,7 +5,7 @@ package avi
 
 import "github.com/hashicorp/terraform-plugin-sdk/v2/helper/schema"
 
-// nolint
+//nolint
 func dataSourceAviIpAddrGroup() *schema.Resource {
 	return &schema.Resource{
 		Read: ResourceAviIpAddrGroupRead,

diff --git a/avi/datasource_avi_ipamdnsproviderprofile.go b/avi/datasource_avi_ipamdnsproviderprofile.go
@@ -5,7 +5,7 @@ package avi
 
 import "github.com/hashicorp/terraform-plugin-sdk/v2/helper/schema"
 
-// nolint
+//nolint
 func dataSourceAviIpamDnsProviderProfile() *schema.Resource {
 	return &schema.Resource{
 		Read: ResourceAviIpamDnsProviderProfileRead,

diff --git a/avi/resource_avi_customipamdnsprofile.go b/avi/resource_avi_customipamdnsprofile.go
@@ -8,7 +8,7 @@ import (
 	"log"
 )
 
-// nolint
+//nolint
 func ResourceCustomIpamDnsProfileSchema() map[string]*schema.Schema {
 	return map[string]*schema.Schema{
 		"configpb_attributes": {
@@ -43,7 +43,7 @@ func ResourceCustomIpamDnsProfileSchema() map[string]*schema.Schema {
 	}
 }
 
-// nolint
+//nolint
 func resourceAviCustomIpamDnsProfile() *schema.Resource {
 	return &schema.Resource{
 		Create: resourceAviCustomIpamDnsProfileCreate,
@@ -57,13 +57,13 @@ func resourceAviCustomIpamDnsProfile() *schema.Resource {
 	}
 }
 
-// nolint
+//nolint
 func ResourceCustomIpamDnsProfileImporter(d *schema.ResourceData, m interface{}) ([]*schema.ResourceData, error) {
 	s := ResourceCustomIpamDnsProfileSchema()
 	return ResourceImporter(d, m, "customipamdnsprofile", s)
 }
 
-// nolint
+//nolint
 func ResourceAviCustomIpamDnsProfileRead(d *schema.ResourceData, meta interface{}) error {
 	s := ResourceCustomIpamDnsProfileSchema()
 	err := APIRead(d, meta, "customipamdnsprofile", s)
@@ -73,7 +73,7 @@ func ResourceAviCustomIpamDnsProfileRead(d *schema.ResourceData, meta interface{
 	return err
 }
 
-// nolint
+//nolint
 func resourceAviCustomIpamDnsProfileCreate(d *schema.ResourceData, meta interface{}) error {
 	s := ResourceCustomIpamDnsProfileSchema()
 	err := APICreate(d, meta, "customipamdnsprofile", s)
@@ -83,7 +83,7 @@ func resourceAviCustomIpamDnsProfileCreate(d *schema.ResourceData, meta interfac
 	return err
 }
 
-// nolint
+//nolint
 func resourceAviCustomIpamDnsProfileUpdate(d *schema.ResourceData, meta interface{}) error {
 	s := ResourceCustomIpamDnsProfileSchema()
 	var err error
@@ -94,7 +94,7 @@ func resourceAviCustomIpamDnsProfileUpdate(d *schema.ResourceData, meta interfac
 	return err
 }
 
-// nolint
+//nolint
 func resourceAviCustomIpamDnsProfileDelete(d *schema.ResourceData, meta interface{}) error {
 	var err error
 	if APIDeleteSystemDefaultCheck(d) {

diff --git a/avi/resource_avi_customipamdnsprofile_test.go b/avi/resource_avi_customipamdnsprofile_test.go
@@ -43,7 +43,7 @@ func TestAVICustomIpamDnsProfileBasic(t *testing.T) {
 
 }
 
-// nolint
+//nolint
 func testAccCheckAVICustomIpamDnsProfileExists(resourcename string) resource.TestCheckFunc {
 	return func(s *terraform.State) error {
 		conn := testAccProvider.Meta().(*clients.AviClient).AviSession
@@ -67,7 +67,7 @@ func testAccCheckAVICustomIpamDnsProfileExists(resourcename string) resource.Tes
 
 }
 
-// nolint
+//nolint
 func testAccCheckAVICustomIpamDnsProfileDestroy(s *terraform.State) error {
 	conn := testAccProvider.Meta().(*clients.AviClient).AviSession
 	var obj interface{}
@@ -92,7 +92,7 @@ func testAccCheckAVICustomIpamDnsProfileDestroy(s *terraform.State) error {
 	return nil
 }
 
-// nolint
+//nolint
 const testAccAVICustomIpamDnsProfileConfig = `
 data "avi_tenant" "default_tenant"{
     name= "admin"
@@ -104,7 +104,7 @@ resource "avi_customipamdnsprofile" "testCustomIpamDnsProfile" {
 }
 `
 
-// nolint
+//nolint
 const testAccAVICustomIpamDnsProfileupdatedConfig = `
 data "avi_tenant" "default_tenant"{
     name= "admin"

diff --git a/avi/resource_avi_dnspolicy.go b/avi/resource_avi_dnspolicy.go
@@ -8,7 +8,7 @@ import (
 	"log"
 )
 
-// nolint
+//nolint
 func ResourceDnsPolicySchema() map[string]*schema.Schema {
 	return map[string]*schema.Schema{
 		"configpb_attributes": {
@@ -60,7 +60,7 @@ func ResourceDnsPolicySchema() map[string]*schema.Schema {
 	}
 }
 
-// nolint
+//nolint
 func resourceAviDnsPolicy() *schema.Resource {
 	return &schema.Resource{
 		Create: resourceAviDnsPolicyCreate,
@@ -74,13 +74,13 @@ func resourceAviDnsPolicy() *schema.Resource {
 	}
 }
 
-// nolint
+//nolint
 func ResourceDnsPolicyImporter(d *schema.ResourceData, m interface{}) ([]*schema.ResourceData, error) {
 	s := ResourceDnsPolicySchema()
 	return ResourceImporter(d, m, "dnspolicy", s)
 }
 
-// nolint
+//nolint
 func ResourceAviDnsPolicyRead(d *schema.ResourceData, meta interface{}) error {
 	s := ResourceDnsPolicySchema()
 	err := APIRead(d, meta, "dnspolicy", s)
@@ -90,7 +90,7 @@ func ResourceAviDnsPolicyRead(d *schema.ResourceData, meta interface{}) error {
 	return err
 }
 
-// nolint
+//nolint
 func resourceAviDnsPolicyCreate(d *schema.ResourceData, meta interface{}) error {
 	s := ResourceDnsPolicySchema()
 	err := APICreate(d, meta, "dnspolicy", s)
@@ -100,7 +100,7 @@ func resourceAviDnsPolicyCreate(d *schema.ResourceData, meta interface{}) error
 	return err
 }
 
-// nolint
+//nolint
 func resourceAviDnsPolicyUpdate(d *schema.ResourceData, meta interface{}) error {
 	s := ResourceDnsPolicySchema()
 	var err error
@@ -111,7 +111,7 @@ func resourceAviDnsPolicyUpdate(d *schema.ResourceData, meta interface{}) error
 	return err
 }
 
-// nolint
+//nolint
 func resourceAviDnsPolicyDelete(d *schema.ResourceData, meta interface{}) error {
 	var err error
 	if APIDeleteSystemDefaultCheck(d) {

diff --git a/avi/resource_avi_dnspolicy_test.go b/avi/resource_avi_dnspolicy_test.go
@@ -43,7 +43,7 @@ func TestAVIDnsPolicyBasic(t *testing.T) {
 
 }
 
-// nolint
+//nolint
 func testAccCheckAVIDnsPolicyExists(resourcename string) resource.TestCheckFunc {
 	return func(s *terraform.State) error {
 		conn := testAccProvider.Meta().(*clients.AviClient).AviSession
@@ -67,7 +67,7 @@ func testAccCheckAVIDnsPolicyExists(resourcename string) resource.TestCheckFunc
 
 }
 
-// nolint
+//nolint
 func testAccCheckAVIDnsPolicyDestroy(s *terraform.State) error {
 	conn := testAccProvider.Meta().(*clients.AviClient).AviSession
 	var obj interface{}
@@ -92,7 +92,7 @@ func testAccCheckAVIDnsPolicyDestroy(s *terraform.State) error {
 	return nil
 }
 
-// nolint
+//nolint
 const testAccAVIDnsPolicyConfig = `
 data "avi_tenant" "default_tenant"{
     name= "admin"
@@ -104,7 +104,7 @@ resource "avi_dnspolicy" "testDnsPolicy" {
 }
 `
 
-// nolint
+//nolint
 const testAccAVIDnsPolicyupdatedConfig = `
 data "avi_tenant" "default_tenant"{
     name= "admin"