Add DHCP binding support for NSX-T Org Networks (vcd_nsxt_network_dhcp_binding) #1039
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Dainius Serplis <dserplis@vmware.com>
Didainius
changed the title
Signed-off-by: Dainius Serplis <dserplis@vmware.com>
Signed-off-by: Dainius Serplis <dserplis@vmware.com>
Signed-off-by: Dainius Serplis <dserplis@vmware.com>
Signed-off-by: Dainius Serplis <dserplis@vmware.com>
Signed-off-by: Dainius Serplis <dserplis@vmware.com>
Signed-off-by: Dainius Serplis <dserplis@vmware.com>
Didainius
requested review from
lvirbalas,
adambarreiro,
dataclouder and
adezxc
as code owners
adambarreiro
reviewed
Apr 4, 2023
lvirbalas
reviewed
Apr 5, 2023
Signed-off-by: Dainius Serplis <dserplis@vmware.com>
adezxc
suggested changes
Apr 6, 2023
Signed-off-by: Dainius Serplis <dserplis@vmware.com>
lvirbalas
approved these changes
Apr 7, 2023
adambarreiro
approved these changes
Apr 10, 2023
adezxc
approved these changes
Apr 12, 2023
Signed-off-by: Dainius Serplis <dserplis@vmware.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces resource and data source
vcd_nsxt_network_dhcp_bindingdedicated to the managment of DHCP Bindings of NSX-T Org VDC networks. (Closes #907)Note. While technically it has support for IPv4 and IPv6 bindings, IPv6 support remains undocumented because Terraform provider lacks a few building blocks to enable IPv6 support for DHCP bindings themselves. These settings remain absent from resource configuration for time being.