Improve vcd_nsxt_edgegateway memory performance #1047
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sses' memory footprint Signed-off-by: Dainius Serplis <dserplis@vmware.com>
Signed-off-by: Dainius Serplis <dserplis@vmware.com>
Didainius
force-pushed
the
improve-edge-memory
branch
from
1a6e0e1
to
35bf689
Compare
Signed-off-by: Dainius Serplis <dserplis@vmware.com>
Didainius
force-pushed
the
improve-edge-memory
branch
from
35bf689
to
eeb0a93
Compare
Signed-off-by: Dainius Serplis <dserplis@vmware.com>
Didainius
requested review from
lvirbalas,
adambarreiro,
dataclouder and
adezxc
as code owners
adambarreiro
approved these changes
Apr 17, 2023
adezxc
approved these changes
Apr 17, 2023
dataclouder
approved these changes
Apr 18, 2023
Signed-off-by: Dainius Serplis <dserplis@vmware.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Main fix and description is in go-vcloud-director SDK pull request - vmware/go-vcloud-director#567
Test
TestAccVcdNsxtEdgeGatewayAutoAllocationUsedAndUnusedIpspatched to allocate a/16size subnet with65533IPs which uses only 18MB of memory for 2 read operations.With the
TEST_VCD_HIGH_MEMenvironment variable one can optionally enable allocation/8IPv4 subnet with16777213. That might take roughly 2GB perreadoperation.This is a sample memory usage with 65533 IPs in
/16