Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update CSE installation guide to use CSE v4.1 #1063

Merged
merged 88 commits into from
Nov 7, 2023
Merged

Update CSE installation guide to use CSE v4.1 #1063

merged 88 commits into from
Nov 7, 2023

Conversation

adambarreiro
Copy link
Collaborator

@adambarreiro adambarreiro commented Jun 2, 2023 •
edited
Loading

⚠️ This PR includes #1117

This PR updates the CSE install guide to use v4.1.

Highlights:

  • v4.0 schemas and entity templates are preserved under v4.0 folder.
  • v4.1 lives inside a new v4.1 folder.
  • The two steps of the installation are now split into tinier .tf files that are easier to understand.
  • The installation guide does not require UI anymore, thanks to vcd_api_token resource.
  • Added a new section in the guide to Upgrade from v4.0 to v4.1.

Init
37e9d32 
Signed-off-by: abarreiro <abarreiro@vmware.com>
abarreiro added 21 commits September 7, 2023 11:46
#
3cef335 
Signed-off-by: abarreiro <abarreiro@vmware.com>
#
752dfb4 
Signed-off-by: abarreiro <abarreiro@vmware.com>
WIP. tests fail
3de8de8 
Signed-off-by: abarreiro <abarreiro@vmware.com>
WIP
f8e90c7 
Signed-off-by: abarreiro <abarreiro@vmware.com>
Fixe
1155590 
Signed-off-by: abarreiro <abarreiro@vmware.com>
Refactor, tests pass
4057ff5 
Signed-off-by: abarreiro <abarreiro@vmware.com>
Refactor, tests pass
f49fca1 
Signed-off-by: abarreiro <abarreiro@vmware.com>
Docs
a7dde48 
Signed-off-by: abarreiro <abarreiro@vmware.com>
Docs
582da89 
Signed-off-by: abarreiro <abarreiro@vmware.com>
Docs
5df78ce 
Signed-off-by: abarreiro <abarreiro@vmware.com>
Improvements
8ec4b0a 
Signed-off-by: abarreiro <abarreiro@vmware.com>
fmt
8f059cf 
Signed-off-by: abarreiro <abarreiro@vmware.com>
#
19a4e41 
Signed-off-by: abarreiro <abarreiro@vmware.com>
#
89d8219 
Signed-off-by: abarreiro <abarreiro@vmware.com>
#
b4807bf 
Signed-off-by: abarreiro <abarreiro@vmware.com>
#
8ecc295 
Signed-off-by: abarreiro <abarreiro@vmware.com>
#
fcbb663 
Signed-off-by: abarreiro <abarreiro@vmware.com>
fmt
73ceec8 
Signed-off-by: abarreiro <abarreiro@vmware.com>
switched to experimental
4f589da 
Signed-off-by: abarreiro <abarreiro@vmware.com>
Merge add-rde-behavior-invocation
ec76905 
Signed-off-by: abarreiro <abarreiro@vmware.com>
Upgrade
40617e0 
Signed-off-by: abarreiro <abarreiro@vmware.com>
@adambarreiro adambarreiro changed the title Improve CSE guide Update CSE guide to use CSE v4.1 and add section to upgrade the installation/clusters Sep 12, 2023
abarreiro added 6 commits September 12, 2023 15:15
#
c7bdb26 
Signed-off-by: abarreiro <abarreiro@vmware.com>
#
d96a140 
Signed-off-by: abarreiro <abarreiro@vmware.com>
#
653dd2b 
Signed-off-by: abarreiro <abarreiro@vmware.com>
Rights
a2547ab 
Signed-off-by: abarreiro <abarreiro@vmware.com>
Rights
0a3a511 
Signed-off-by: abarreiro <abarreiro@vmware.com>
Add VCDKEConfig template
7df1922 
Signed-off-by: abarreiro <abarreiro@vmware.com>
abarreiro added 4 commits October 11, 2023 17:23
fmt
8b42588 
Signed-off-by: abarreiro <abarreiro@vmware.com>
fmt
bd814dd 
Signed-off-by: abarreiro <abarreiro@vmware.com>
Merge
58bafbd 
Signed-off-by: abarreiro <abarreiro@vmware.com>
Fix guide
688cbf3 
Signed-off-by: abarreiro <abarreiro@vmware.com>
@adambarreiro adambarreiro mentioned this pull request Oct 18, 2023
Merged
adezxc
adezxc reviewed Oct 23, 2023
View reviewed changes
Copy link

@adezxc adezxc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First scan, for now it looks good to me, but will try to install/upgrade 4.1 locally to see if I bump into any issues.

website/docs/guides/container_service_extension_install.html.markdown Outdated Show resolved Hide resolved
website/docs/guides/container_service_extension_install.html.markdown Outdated Show resolved Hide resolved
website/docs/guides/container_service_extension_install.html.markdown Outdated Show resolved Hide resolved
website/docs/guides/container_service_extension_install.html.markdown Outdated Show resolved Hide resolved
website/docs/guides/container_service_extension_install.html.markdown Outdated Show resolved Hide resolved
website/docs/guides/container_service_extension_install.html.markdown Outdated Show resolved Hide resolved
website/docs/guides/container_service_extension_install.html.markdown Outdated Show resolved Hide resolved
website/docs/guides/container_service_extension_install.html.markdown Outdated Show resolved Hide resolved
examples/container-service-extension/v4.1/install/step2/3.11-cse-install-7-cse-server-init.tf Outdated Show resolved Hide resolved
examples/container-service-extension/v4.1/install/step2/3.11-cse-install-7-cse-server-init.tf Show resolved Hide resolved
abarreiro added 3 commits October 23, 2023 15:56
Apply suggestion
f8111d9 
Signed-off-by: abarreiro <abarreiro@vmware.com>
Merge
d045f12 
Signed-off-by: abarreiro <abarreiro@vmware.com>
Merge
b8b6c41 
Signed-off-by: abarreiro <abarreiro@vmware.com>
dataclouder
dataclouder reviewed Nov 2, 2023
View reviewed changes
website/docs/guides/container_service_extension_install.html.markdown Outdated Show resolved Hide resolved
website/docs/guides/container_service_extension_install.html.markdown Outdated Show resolved Hide resolved
website/docs/guides/container_service_extension_install.html.markdown Outdated Show resolved Hide resolved
website/docs/guides/container_service_extension_install.html.markdown Outdated Show resolved Hide resolved
website/docs/guides/container_service_extension_install.html.markdown Outdated Show resolved Hide resolved
website/docs/guides/container_service_extension_install.html.markdown Outdated Show resolved Hide resolved
website/docs/guides/container_service_extension_install.html.markdown Outdated Show resolved Hide resolved
website/docs/guides/container_service_extension_install.html.markdown Outdated Show resolved Hide resolved
website/docs/guides/container_service_extension_install.html.markdown Outdated Show resolved Hide resolved
website/docs/guides/container_service_extension_install.html.markdown Outdated Show resolved Hide resolved
abarreiro added 3 commits November 3, 2023 09:32
Apply suggestions
cb13bd7 
Signed-off-by: abarreiro <abarreiro@vmware.com>
fmt
d5fe1e5 
Signed-off-by: abarreiro <abarreiro@vmware.com>
#
1f27f24 
Signed-off-by: abarreiro <abarreiro@vmware.com>
Apply suggestion
65b1268 
Signed-off-by: abarreiro <abarreiro@vmware.com>
adezxc
adezxc approved these changes Nov 6, 2023
View reviewed changes
Copy link

@adezxc adezxc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got a successful deployment of the cluster after some attempts, thanks for this!

lvirbalas
lvirbalas reviewed Nov 6, 2023
View reviewed changes
Copy link
Collaborator

@lvirbalas lvirbalas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doc review comments.

website/docs/guides/container_service_extension_3_1_x.html.markdown Outdated Show resolved Hide resolved
website/vcd.erb Outdated Show resolved Hide resolved
website/docs/guides/container_service_extension_install.html.markdown Outdated Show resolved Hide resolved
website/docs/guides/container_service_extension_install.html.markdown Outdated Show resolved Hide resolved
website/docs/guides/container_service_extension_install.html.markdown Outdated Show resolved Hide resolved
Didainius
Didainius approved these changes Nov 6, 2023
View reviewed changes
Copy link
Collaborator

@Didainius Didainius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this needs a changelog record - even if it is in Notes section - it is important to catch eyes, although IMO Improvements section is also a good place.

website/docs/guides/container_service_extension_install.html.markdown Outdated Show resolved Hide resolved
website/docs/guides/container_service_extension_install.html.markdown Outdated Show resolved Hide resolved
examples/container-service-extension/v4.1/install/step2/3.11-cse-install-4-provider-config.tf Outdated Show resolved Hide resolved
abarreiro added 6 commits November 6, 2023 15:30
Add changelog
14f20b5 
Signed-off-by: abarreiro <abarreiro@vmware.com>
Add changelog
14dcecf 
Signed-off-by: abarreiro <abarreiro@vmware.com>
Apply suggestions
e8c1d23 
Signed-off-by: abarreiro <abarreiro@vmware.com>
Apply suggestion
6e47985 
Signed-off-by: abarreiro <abarreiro@vmware.com>
Self review
fdb5c46 
Signed-off-by: abarreiro <abarreiro@vmware.com>
Self review
f090c97 
Signed-off-by: abarreiro <abarreiro@vmware.com>
@adambarreiro adambarreiro merged commit b5b1a70 into vmware:main Nov 7, 2023
3 checks passed
@adambarreiro adambarreiro deleted the upgrade-cse41 branch November 7, 2023 10:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adezxc adezxc adezxc approved these changes

@Didainius Didainius Didainius approved these changes

@dataclouder dataclouder dataclouder approved these changes

@lvirbalas lvirbalas lvirbalas approved these changes

Assignees

@adambarreiro adambarreiro

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@adambarreiro @lvirbalas @dataclouder @Didainius @adezxc