Improve Behavior definitions to allow complex Execution properties

[adambarreiro]

Problem

With v3.10.0, the new resources vcd_rde_interface_behavior and vcd_rde_type_behavior allowed to define Behaviors for RDE Interfaces and RDE Types respectively.

The Behaviors could be defined with the generic map execution argument, but the problem is that Terraform only supports simple maps of string->string, where one could be able to define executions of more complex structures, like a WebHook type does:

{
      "type":"WebHook",
      "id":"testWebHook",
      "href":"https://hooks.slack.com:443/services/T07UZFN0N/B01EW5NC42D/rfjhHCGIwzuzQFrpPZiuLkIX",
      "key":"secretKey",
      "execution_properties": { <--- PROBLEM! This is not possible with a TypeMap!
         "template":{
            "content":"<template_content_string>"
         },
         "_secure_token":"secureToken",
         "invocation_timeout":7
      }
   }

Solution

Add a new attribute execution_json which is a plain string that represents a JSON. Both execution and execution_json will live together, the first one being now just syntactic sugar for the latter.

The challenge here is that the WebHook behavior type uses a special _secure_ and _internal_ prefixes for fields that are write-only. So once created, they're never recovered from VCD. This causes dirty plans all the time, where the Provider asks for updates all the time. To avoid that, a new DiffSuppressFunc has been implemented: hasBehaviorExecutionChanged, which ignores secure fields if the attribute always_update_secure_execution_properties is disabled.

Tests

☑️ Acceptance tests

go test -tags rde -v -timeout 0

☑️ Binary tests

make test-binary-prepare
cd vcd/test-artifacts
./test-binary.sh tags rde

☑️ Upgrade tests

make test-upgrade-prepare
cd vcd/test-artifacts
./test-binary.sh upgrade v3.13.0 v3.14.0

[Didainius]

Tests pass on 10.6 and 10.4