-
Notifications
You must be signed in to change notification settings - Fork 112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for overriding VM template disks in fast provisioned VDCs #1206
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Didainius
force-pushed
the
vm-with-resizing
branch
from
February 8, 2024 04:55
43b4878
to
d913fab
Compare
Signed-off-by: Dainius Serplis <dserplis@vmware.com>
Didainius
force-pushed
the
vm-with-resizing
branch
from
February 8, 2024 04:59
d913fab
to
e617507
Compare
Didainius
changed the title
Add support for VM disk consolidation
Add support for overriding VM template disks in fast provisioned VDCs
Feb 8, 2024
Signed-off-by: Dainius Serplis <dserplis@vmware.com>
Signed-off-by: Dainius Serplis <dserplis@vmware.com>
Signed-off-by: Dainius Serplis <dserplis@vmware.com>
Signed-off-by: Dainius Serplis <dserplis@vmware.com>
Didainius
requested review from
lvirbalas,
adambarreiro and
dataclouder
as code owners
February 12, 2024 04:48
lvirbalas
approved these changes
Feb 12, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for a great feature!
adambarreiro
approved these changes
Feb 12, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, vm
tests passed on 10.5.1
dataclouder
reviewed
Feb 22, 2024
dataclouder
approved these changes
Feb 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
override_template_disk
configuration invcd_vapp_vm
andvcd_vm
allows users to change template disk size. The current limitation is that it can only be done in non fast provisioned VDCs.This PR adds
consolidate_disks_on_create
option tovcd_vapp_vm
andvcd_vm
that can perform disk consolidation beforeoverride_template_disk
configuration is applied. The effect is that a user will be able to change template disk size when creating VMs in fast provisioned VDCs.Note. The user performing this operation will need to have
vApp: VM Migrate, Force Undeploy, Relocate, Consolidate
right.Closes #1000