Support creating templates from existing vApps #1215
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Didainius
force-pushed
the
pr-capture-template
branch
from
15af1ba
to
040c5dc
Compare
Didainius
force-pushed
the
pr-capture-template
branch
from
040c5dc
to
0a7bf61
Compare
Signed-off-by: Dainius Serplis <dserplis@vmware.com>
Didainius
force-pushed
the
pr-capture-template
branch
from
9a686e4
to
04707d0
Compare
Signed-off-by: Dainius Serplis <dserplis@vmware.com>
Signed-off-by: Dainius Serplis <dserplis@vmware.com>
Didainius
requested review from
lvirbalas,
adambarreiro and
dataclouder
as code owners
lvirbalas
approved these changes
Mar 5, 2024
adambarreiro
reviewed
Mar 5, 2024
Signed-off-by: Dainius Serplis <dserplis@vmware.com>
adambarreiro
reviewed
Mar 6, 2024
Signed-off-by: Dainius Serplis <dserplis@vmware.com>
adambarreiro
approved these changes
Mar 6, 2024
Signed-off-by: Dainius Serplis <dserplis@vmware.com>
Signed-off-by: Dainius Serplis <dserplis@vmware.com>
dataclouder
reviewed
Mar 8, 2024
Signed-off-by: Dainius Serplis <dserplis@vmware.com>
dataclouder
approved these changes
Mar 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for creating (capturing) vApp templates from existing vApps.
The main functionality is added to resource
vcd_catalog_vapp_templatevia new configuration blockcapture_vapp. Previously this resource was able to upload a vApp template using ova_path or pass ovf_url and now it has third optioncapture_vapp.Additionally a few convenience features were added to better acomodate vApp capturing support:
vcd_vapp_vm/vcd_vmexpose computed fieldvapp_id- this is especially important for Standalone VMs (vcd_vm) as they do have a parent vApp that is hidden. When creating a vApp template from standalone VM, one must supply that parent vApp ID (newvapp_idfield), not the VM ID.vcd_catalog_vapp_templateexposes additional attributecatalog_item_idfor related Catalog ItemID. It can be useful if one wishes to overwrite existing template when using
capture_vapp.0.overwrite_catalog_item_idfunctionalityAcceptance tests passed on 10.4.0, 10.4.2, 10.5.1