Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor resources to align with VCD and TM tests #1355

Merged
merged 24 commits into from
Nov 28, 2024
Merged

Refactor resources to align with VCD and TM tests #1355

merged 24 commits into from
Nov 28, 2024

Conversation

Didainius
Copy link
Collaborator

@Didainius Didainius commented Nov 20, 2024 •
edited
Loading

  • Revalidates that acceptance tests can be run on VCD
  • Renames vcd_vcenter resource and data source to vcd_tm_vcenter. Returns the classic data source vcd_vcenter that was available before.
  • Renames vcd_nsxt_manager -> vcd_tm_nsxt_manager as it is only available in TM. Returns the classic data source vcd_nsxt_manager that was available before.
  • Adds make testacc-coverage command to run acceptance tests with coverage report
  • Adjusts TestAccDataSourceNotFound to avoid picking Tenant Manager tests (prefix vcd_tm*)

@Didainius
Split vcd_nsxt_manager data source and vcd_tm_nsxt_manager resources …
5b2b86c 
…+ data source

Signed-off-by: Dainius Serplis <dserplis@vmware.com>
@Didainius
Test and doc references + changelog
ca9a6d6 
Signed-off-by: Dainius Serplis <dserplis@vmware.com>
@Didainius
Add make testacc-coverage
7cb5ff5 
Signed-off-by: Dainius Serplis <dserplis@vmware.com>
@Didainius
Remove -race flag because it requires CGO_ENABLED
096f862 
Signed-off-by: Dainius Serplis <dserplis@vmware.com>
@Didainius
Fix makefile to run with coverage if requested
ee2c5b4 
Signed-off-by: Dainius Serplis <dserplis@vmware.com>
@Didainius
Improve gitignore
5b91788 
Signed-off-by: Dainius Serplis <dserplis@vmware.com>
@Didainius
Run 'unit' tests as well during testacc
7270276 
Signed-off-by: Dainius Serplis <dserplis@vmware.com>
@Didainius
Recalibrate 'vcd_vcenter' data source to be backwards compatible
91e9c5d 
Signed-off-by: Dainius Serplis <dserplis@vmware.com>
@Didainius
Fix TM vcenter test
89a2c69 
Signed-off-by: Dainius Serplis <dserplis@vmware.com>
@Didainius
Run unit tests together with acceptance ones
745837f 
Signed-off-by: Dainius Serplis <dserplis@vmware.com>
@Didainius
Adjust TestAccDataSourceNotFound
a239253 
Signed-off-by: Dainius Serplis <dserplis@vmware.com>
@Didainius Didainius changed the title vcd_nsxt_manager and vcd_tm_nsxt_manager Align VCD and TM tests Nov 25, 2024
@Didainius
Self review
eea8853 
Signed-off-by: Dainius Serplis <dserplis@vmware.com>
@Didainius
Bump sdk
2477e59 
Signed-off-by: Dainius Serplis <dserplis@vmware.com>
@Didainius
Merge main
30ad787 
Signed-off-by: Dainius Serplis <dserplis@vmware.com>
@Didainius
Update changelog
ecf2880 
Signed-off-by: Dainius Serplis <dserplis@vmware.com>
@Didainius
Make 'status' a computed field
2996229 
Signed-off-by: Dainius Serplis <dserplis@vmware.com>
@Didainius
bump sdk
5dc2c14 
Signed-off-by: Dainius Serplis <dserplis@vmware.com>
@Didainius Didainius marked this pull request as ready for review November 26, 2024 11:40
@lvirbalas
Copy link
Collaborator

Renames vcd_nsxt_manager -> vcd_tm_nsxt_manager as it is only available in TM.

If this PR is renaming resources, let's give the PR a more serious title. Right now it looks as if it's only changing tests:
"Align VCD and TM tests"

adambarreiro
adambarreiro reviewed Nov 26, 2024
View reviewed changes
Copy link
Collaborator

@adambarreiro adambarreiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First scan

vcd/datasource_vcd_tm_nsxt_manager.go Outdated Show resolved Hide resolved
website/docs/d/tm_nsxt_manager.html.markdown Outdated Show resolved Hide resolved
website/docs/d/tm_nsxt_manager.html.markdown Outdated Show resolved Hide resolved
@Didainius
Address comments
a8da70c 
Signed-off-by: Dainius Serplis <dserplis@vmware.com>
@Didainius Didainius changed the title Align VCD and TM tests Refactor resources to align with VCD and TM tests Nov 27, 2024
@Didainius
vcd_vcenter -> vcd_tm_vcenter
f6397f5 
Signed-off-by: Dainius Serplis <dserplis@vmware.com>
@Didainius
checkout vcd_vcenter from main
6886247 
Signed-off-by: Dainius Serplis <dserplis@vmware.com>
@Didainius
Checkout correct vcd_vcenter
5e92381 
Signed-off-by: Dainius Serplis <dserplis@vmware.com>
@Didainius
Add provider
9f38478 
Signed-off-by: Dainius Serplis <dserplis@vmware.com>
@Didainius
Add changelog
2c83da6 
Signed-off-by: Dainius Serplis <dserplis@vmware.com>
@Didainius
Address comment
210eb8e 
Signed-off-by: Dainius Serplis <dserplis@vmware.com>
@Didainius Didainius merged commit 2a414fe into vmware:main Nov 28, 2024
3 checks passed
@Didainius Didainius deleted the tmvcd branch November 28, 2024 15:39
@Didainius Didainius mentioned this pull request Jan 21, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adambarreiro adambarreiro adambarreiro approved these changes

@lvirbalas lvirbalas lvirbalas approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Didainius @lvirbalas @adambarreiro