Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing test fields for TestAccVcdNsxtEdgeBgpConfigIntegrationVdc and TestAccVcdNsxtEdgeBgpConfigIntegrationVdcGroup #958

Merged
merged 5 commits into from
Jan 18, 2023
Merged

Add missing test fields for TestAccVcdNsxtEdgeBgpConfigIntegrationVdc and TestAccVcdNsxtEdgeBgpConfigIntegrationVdcGroup #958

merged 5 commits into from
Jan 18, 2023

Conversation

Didainius
Copy link
Collaborator

Tests TestAccVcdNsxtEdgeBgpConfigIntegrationVdc and TestAccVcdNsxtEdgeBgpConfigIntegrationVdcGroup had missing Name field. As a result binary tests would end up with name being name = "*** MISSING FIELD [TestName] from func vcd.TestAccVcdNsxtEdgeBgpConfigIntegrationVdcGroup-1".

This PR adds missing variables.

Tests still pass.

@Didainius
Add missing test fields
e21164c 
Signed-off-by: Dainius Serplis <dserplis@vmware.com>
@Didainius Didainius changed the title Add missing test fields Add missing test fields for TestAccVcdNsxtEdgeBgpConfigIntegrationVdc and TestAccVcdNsxtEdgeBgpConfigIntegrationVdcGroup Dec 14, 2022
@Didainius
Merge branch 'main' into missing-test-fields
f9c6418 
Signed-off-by: Dainius Serplis <dserplis@vmware.com>
@Didainius Didainius marked this pull request as ready for review January 16, 2023 10:31
adambarreiro
adambarreiro reviewed Jan 16, 2023
View reviewed changes
Copy link
Collaborator

@adambarreiro adambarreiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix! Should we add a changelog entry for this one?

@Didainius
Add changelog note
f4e2c0b 
Signed-off-by: Dainius Serplis <dserplis@vmware.com>
@Didainius
Copy link
Collaborator Author

Should we add a changelog entry for this one?

Yes. Added - thanks

lvirbalas
lvirbalas approved these changes Jan 18, 2023
View reviewed changes
Copy link
Collaborator

@lvirbalas lvirbalas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One suggestion, thanks!

.changes/v3.9.0/958-notes.md Outdated Show resolved Hide resolved
@Didainius
Merge branch 'main' into missing-test-fields
7b3126a 
Signed-off-by: Dainius Serplis <dserplis@vmware.com>
@Didainius
Address comment
210bf22 
Signed-off-by: Dainius Serplis <dserplis@vmware.com>
@Didainius Didainius merged commit 67e0940 into vmware:main Jan 18, 2023
@Didainius Didainius deleted the missing-test-fields branch January 18, 2023 12:32
@dataclouder dataclouder mentioned this pull request Apr 25, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dataclouder dataclouder dataclouder approved these changes

@lvirbalas lvirbalas lvirbalas approved these changes

@adambarreiro adambarreiro adambarreiro approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Didainius @adambarreiro @lvirbalas @dataclouder