Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create catalog renaming tests #992

Merged
merged 17 commits into from
Feb 15, 2023
Merged

Create catalog renaming tests #992

merged 17 commits into from
Feb 15, 2023

Conversation

adezxc
Copy link

@adezxc adezxc commented Feb 2, 2023 •
edited
Loading

About

This PR creates TestAccVcdCatalogRenamer test. It consists out of three steps: which are

  1. Create a catalog and inside of it upload a vApp template and media file, and create VMs out of them.
  2. Rename the catalog and check that the ID stays the same.
  3. Check that the contents of the catalog have stayed unchanged.

@vmwclabot
Copy link
Member

@adezxc, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding Signed-off-by: John Doe <john.doe@email.org> to the last line of each Git commit message. The e-mail address used to sign must match the e-mail address of the Git author. Click here to view the Developer Certificate of Origin agreement.

1 similar comment
@vmwclabot
Copy link
Member

@adezxc, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding Signed-off-by: John Doe <john.doe@email.org> to the last line of each Git commit message. The e-mail address used to sign must match the e-mail address of the Git author. Click here to view the Developer Certificate of Origin agreement.

@vmwclabot
Copy link
Member

@adezxc, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding Signed-off-by: John Doe <john.doe@email.org> to the last line of each Git commit message. The e-mail address used to sign must match the e-mail address of the Git author. Click here to view the Developer Certificate of Origin agreement.

1 similar comment
@vmwclabot
Copy link
Member

@adezxc, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding Signed-off-by: John Doe <john.doe@email.org> to the last line of each Git commit message. The e-mail address used to sign must match the e-mail address of the Git author. Click here to view the Developer Certificate of Origin agreement.

@vmwclabot
Copy link
Member

@adezxc, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding Signed-off-by: John Doe <john.doe@email.org> to the last line of each Git commit message. The e-mail address used to sign must match the e-mail address of the Git author. Click here to view the Developer Certificate of Origin agreement.

1 similar comment
@vmwclabot
Copy link
Member

@adezxc, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding Signed-off-by: John Doe <john.doe@email.org> to the last line of each Git commit message. The e-mail address used to sign must match the e-mail address of the Git author. Click here to view the Developer Certificate of Origin agreement.

create catalog renaming tests
d4ae683 
Signed-off-by: Adam Jasinski <jasinskia@vmware.com>
merge main
69ed17e 
Signed-off-by: Adam Jasinski <jasinskia@vmware.com>
move rename to the last test step
39e5af0 
Signed-off-by: Adam Jasinski <jasinskia@vmware.com>
@adezxc adezxc marked this pull request as draft February 6, 2023 10:25
Adam Jasinski added 6 commits February 6, 2023 19:25
new test created
0409050 
Signed-off-by: Adam Jasinski <jasinskia@vmware.com>
improve renaming test
9a6171f 
Signed-off-by: Adam Jasinski <jasinskia@vmware.com>
fix staticcheck unused code warning
56c578d 
Signed-off-by: Adam Jasinski <jasinskia@vmware.com>
improve rename test more
78583e8 
Signed-off-by: Adam Jasinski <jasinskia@vmware.com>
fix mistype
459d3e4 
Signed-off-by: Adam Jasinski <jasinskia@vmware.com>
remove leftovers from org_user test
24a7cc9 
Signed-off-by: Adam Jasinski <jasinskia@vmware.com>
@adezxc adezxc marked this pull request as ready for review February 7, 2023 20:06
cache ids of vms, media file and vApp template
89f96da 
Signed-off-by: Adam Jasinski <jasinskia@vmware.com>
dataclouder
dataclouder suggested changes Feb 8, 2023
View reviewed changes
vcd/resource_vcd_catalog_test.go Outdated Show resolved Hide resolved
vcd/resource_vcd_catalog_test.go Outdated Show resolved Hide resolved
vcd/resource_vcd_catalog_test.go Outdated Show resolved Hide resolved
vcd/resource_vcd_catalog_test.go Outdated Show resolved Hide resolved
fix duplicate cached ids
a1231df 
Signed-off-by: Adam Jasinski <jasinskia@vmware.com>
Adam Jasinski added 3 commits February 8, 2023 12:52
address comments
b884fb6 
Signed-off-by: Adam Jasinski <jasinskia@vmware.com>
check if resources exist and are deleted properly
7c919c7 
Signed-off-by: Adam Jasinski <jasinskia@vmware.com>
check for catalog existence earlier
022f6b3 
Signed-off-by: Adam Jasinski <jasinskia@vmware.com>
Didainius
Didainius approved these changes Feb 9, 2023
View reviewed changes
Copy link
Collaborator

@Didainius Didainius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. A few tiny comments inline

vcd/resource_vcd_catalog_test.go Outdated Show resolved Hide resolved
.changes/v3.9.0/992-notes.md Outdated Show resolved Hide resolved
address comments
f145c78 
Signed-off-by: Adam Jasinski <jasinskia@vmware.com>
adambarreiro
adambarreiro approved these changes Feb 9, 2023
View reviewed changes
Copy link
Collaborator

@adambarreiro adambarreiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test passed for me, approving! Thanks.

Adam Jasinski added 2 commits February 15, 2023 09:35
update changelog entry
cecb38f 
Signed-off-by: Adam Jasinski <jasinskia@vmware.com>
update changelog entry
69d9a80 
Signed-off-by: Adam Jasinski <jasinskia@vmware.com>
@adezxc adezxc merged commit 5d4333a into vmware:main Feb 15, 2023
@adezxc adezxc deleted the test-rename-catalog branch March 16, 2023 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Didainius Didainius Didainius approved these changes

@dataclouder dataclouder dataclouder approved these changes

@lvirbalas lvirbalas lvirbalas approved these changes

@adambarreiro adambarreiro adambarreiro approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@adezxc @vmwclabot @adambarreiro @lvirbalas @dataclouder @Didainius