fix: missing vds info with r/cluster import

[burnsjared0415]

In order to have a good experience with our community, we recommend that you read the contributing guidelines for making a pull request.

Summary of Pull Request

Updating Cluster import to solve issues where vds is blank on data source.

Type of Pull Request

• This is a bug fix.
• This is an enhancement or feature.
• This is a code style/formatting update.
• This is a documentation update.
• This is a refactoring update.
• This is a chore update
• This is something else.
  Please describe:

Related to Existing Issues

Ref: #210

Test and Documentation Coverage

For bug fixes or features:

• Tests have been completed.
• Documentation has been added/updated.

Breaking Changes?

• Yes, there are breaking changes.
• No, there are no breaking changes.

[tenthirtyam]

The CI caught that the err is assigned but not used.

getFlattenedVdsSpecsForRefs returns both a slice of maps and an error. So the err is necessary to handle potential errors from the apiClient.Clusters.GetVdses.

[burnsjared0415]

here is what the results are now:

 "is_used_by_nsx": true,
                "name": "xxx-vds01",
                "nioc_bandwidth_allocations": [
                  {
                    "limit": 0,
                    "reservation": 0,
                    "shares": 100,
                    "shares_level": "high",
                    "type": "vsan"
                  },
                  {
                    "limit": 0,
                    "reservation": 0,
                    "shares": 25,
                    "shares_level": "low",
                    "type": "vmotion"
                  },
                  {
                    "limit": 0,
                    "reservation": 0,
                    "shares": 25,
                    "shares_level": "low",
                    "type": "vdp"
                  },
                  {
                    "limit": 0,
                    "reservation": 0,
                    "shares": 25,
                    "shares_level": "low",
                    "type": "nfs"
                  },
                  {
                    "limit": 0,
                    "reservation": 0,
                    "shares": 25,
                    "shares_level": "low",
                    "type": "hbr"
                  },
                  {
                    "limit": 0,
                    "reservation": 0,
                    "shares": 25,
                    "shares_level": "low",
                    "type": "iSCSI"
                  },
                  {
                    "limit": 0,
                    "reservation": 0,
                    "shares": 100,
                    "shares_level": "high",
                    "type": "virtualMachine"
                  },
                  {
                    "limit": 0,
                    "reservation": 0,
                    "shares": 50,
                    "shares_level": "normal",
                    "type": "management"
                  },
                  {
                    "limit": 0,
                    "reservation": 0,
                    "shares": 25,
                    "shares_level": "low",
                    "type": "faultTolerance"
                  }
                ],
                "portgroup": [
                  {
                    "active_uplinks": [
                      "uplink1",
                      "uplink2"
                    ],
                    "name": "xxx-pg-mgmt",
                    "transport_type": "MANAGEMENT"
                  },
                  {
                    "active_uplinks": [
                      "uplink1",
                      "uplink2"
                    ],
                    "name": "xxxx-pg-vmotion",
                    "transport_type": "VMOTION"
                  }
                ]
              }
            ]
          },
          "sensitive_attributes": []
        }
      ]
    }
  ],
  "check_results": null
}

[tenthirtyam]

@burnsjared0415 could you address the following issues failing during the linkting?

  Error: internal/cluster/cluster_operations.go:376:21: ineffectual assignment to err (ineffassign)
  	flattenedVdsSpecs, err := getFlattenedVdsSpecsForRefs(ctx, clusterObj.ID, apiClient)
  	                   ^
  Error: internal/cluster/cluster_operations.go:406:21: ineffectual assignment to err (ineffassign)
  	flattenedVdsSpecs, err := getFlattenedVdsSpecsForRefs(ctx, clusterId, apiClient)

[tenthirtyam]

Rebased based on the changes to main recently. Will need updates given the SDK changes.