vdk-core: remove structlog logging override #3066
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Why? Structlog should not override the initial logging config. It applies to logging before vdk is initialized and before any plugins are loaded. If an error happens in vdk_main, the logging config will apply. It should remain in core. It's also not a problem for structlog, because it ejects all logging config just in case. What? Remove the structlog override in core How was this tested? Locally CI What kind of change is this? Bugfix Signed-off-by: Dilyan Marinov <mdilyan@vmware.com>
yonitoo
approved these changes
Jan 31, 2024
duyguHsnHsn
approved these changes
Jan 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why?
Structlog should not override the initial logging config. It applies to logging before vdk is initialized and before any plugins are loaded. If an error happens in vdk_main, the logging config will apply. It should remain in core.
It's also not a problem for structlog, because it ejects all logging config just in case.
What?
Remove the structlog override in core
How was this tested?
Locally
CI
What kind of change is this?
Bugfix