vdk-core: add is_default() function to config #3076
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DeltaMichael
force-pushed
the
person/mdilyan/config-is-default
branch
from
6cd3382
to
0e32258
Compare
gabrielgeorgiev1
approved these changes
Feb 6, 2024
antoniivanov
requested changes
Feb 6, 2024
DeltaMichael
force-pushed
the
person/mdilyan/config-is-default
branch
3 times, most recently
from
8c69032
to
223b807
Compare
antoniivanov
reviewed
Feb 6, 2024
Why? There are cases where we want to know we're using the default value for a config option. One such case is configuration presets #3055 What? Add is_default() to the config object. How was this tested? Unit tests What kind of change is this? Feature/non-breaking Signed-off-by: Dilyan Marinov <mdilyan@vmware.com>
DeltaMichael
force-pushed
the
person/mdilyan/config-is-default
branch
from
223b807
to
0e7073e
Compare
antoniivanov
approved these changes
Feb 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why?
There are cases where we want to know we're using the default value for a config option. One such case is configuration presets
#3055
What?
Add is_default() to the config object.
How was this tested?
Unit tests
What kind of change is this?
Feature/non-breaking